Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 15480004: moving SyncSocket's kInvalidHandle constant (Closed)

Created:
7 years, 7 months ago by cpu_(ooo_6.6-7.5)
Modified:
7 years, 7 months ago
Reviewers:
brettw, scottmg
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

moving SyncSocket's kInvalidHandle constant So it does not get exported in the split dll build. The change is to move the definition into the h and telling the linker to just pick one symbol. This change needs to be undone in the next quarter or so. BUG=237249 TEST=none TBR=brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201690

Patch Set 1 #

Patch Set 2 : better value for -1 #

Patch Set 3 : fix linkage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M base/sync_socket.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M base/sync_socket_win.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
cpu_(ooo_6.6-7.5)
7 years, 7 months ago (2013-05-21 22:54:17 UTC) #1
scottmg
lgtm
7 years, 7 months ago (2013-05-21 22:55:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/15480004/2001
7 years, 7 months ago (2013-05-21 23:01:13 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-21 23:33:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/15480004/2001
7 years, 7 months ago (2013-05-22 00:03:06 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-22 01:24:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/15480004/27001
7 years, 7 months ago (2013-05-22 02:49:33 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 7 months ago (2013-05-22 03:20:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/15480004/27001
7 years, 7 months ago (2013-05-22 17:10:59 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-05-23 04:34:12 UTC) #10
Message was sent while issue was closed.
Change committed as 201690

Powered by Google App Engine
This is Rietveld 408576698