Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 15469002: DevTools: [CodeMirror] update js/css/html modes (Closed)

Created:
7 years, 7 months ago by lushnikov
Modified:
7 years, 7 months ago
Reviewers:
vsevik, apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: [CodeMirror] update js/css/html modes Pull codemirror modes from the upstream. The intent for this change is the codemirror's comment.js plugin which requires modes to have "lineComment" property. BUG=167284 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+498 lines, -309 lines) Patch
M Source/devtools/front_end/CodeMirrorTextEditor.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/cm/css.js View 5 chunks +369 lines, -252 lines 0 comments Download
M Source/devtools/front_end/cm/htmlmixed.js View 4 chunks +43 lines, -23 lines 0 comments Download
M Source/devtools/front_end/cm/javascript.js View 13 chunks +85 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
lushnikov
Please have a look
7 years, 7 months ago (2013-05-20 13:04:56 UTC) #1
apavlov
lgtm
7 years, 7 months ago (2013-05-20 13:59:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/15469002/1
7 years, 7 months ago (2013-05-20 13:59:36 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-20 15:14:03 UTC) #4
Message was sent while issue was closed.
Change committed as 150672

Powered by Google App Engine
This is Rietveld 408576698