Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: chrome/browser/plugins/plugin_installer.cc

Issue 15467002: Remove unused reference to DownloadManager in PluginInstaller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugins/plugin_installer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/plugin_installer.cc
diff --git a/chrome/browser/plugins/plugin_installer.cc b/chrome/browser/plugins/plugin_installer.cc
index bac5705594da229e40172b564db5b9efae94e75c..6cc1b39b7b87b5b6a55aaa451164098d0145f6b9 100644
--- a/chrome/browser/plugins/plugin_installer.cc
+++ b/chrome/browser/plugins/plugin_installer.cc
@@ -17,7 +17,6 @@
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/download_id.h"
#include "content/public/browser/download_item.h"
-#include "content/public/browser/download_manager.h"
#include "content/public/browser/download_save_info.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
@@ -30,7 +29,6 @@
using content::BrowserContext;
using content::BrowserThread;
using content::DownloadItem;
-using content::DownloadManager;
using content::ResourceDispatcherHost;
namespace {
@@ -136,8 +134,6 @@ void PluginInstaller::StartInstalling(const GURL& plugin_url,
FOR_EACH_OBSERVER(PluginInstallerObserver, observers_, DownloadStarted());
Profile* profile =
Profile::FromBrowserContext(web_contents->GetBrowserContext());
- DownloadManager* download_manager =
- BrowserContext::GetDownloadManager(profile);
download_util::RecordDownloadSource(
download_util::INITIATED_BY_PLUGIN_INSTALLER);
BrowserThread::PostTask(
@@ -148,14 +144,11 @@ void PluginInstaller::StartInstalling(const GURL& plugin_url,
web_contents->GetRenderProcessHost()->GetID(),
web_contents->GetRenderViewHost()->GetRoutingID(),
base::Bind(&PluginInstaller::DownloadStarted,
- base::Unretained(this),
- make_scoped_refptr(download_manager))));
+ base::Unretained(this))));
}
-void PluginInstaller::DownloadStarted(
- scoped_refptr<content::DownloadManager> dlm,
- content::DownloadItem* item,
- net::Error error) {
+void PluginInstaller::DownloadStarted(content::DownloadItem* item,
+ net::Error error) {
if (!item) {
DCHECK_NE(net::OK, error);
std::string msg =
« no previous file with comments | « chrome/browser/plugins/plugin_installer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698