Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1575)

Unified Diff: Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp

Issue 15466004: Make image decoders faster by refactoring hot loops that fills the lines of ImageFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make image decoders faster by refactoring hot loops that fills the lines of ImageFrame. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp
diff --git a/Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp b/Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp
index 26171f55dae281d37ebcb21ce8f08c8b957750ed..744e17d9e0d518f4ecfb87f5406dc1df85620b8a 100644
--- a/Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp
+++ b/Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp
@@ -194,8 +194,16 @@ void WEBPImageDecoder::applyColorProfile(const uint8_t* data, size_t dataSize, I
if (qcms_transform* transform = colorTransform())
qcms_transform_data_type(transform, row, row, width, QCMS_OUTPUT_RGBX);
uint8_t* pixel = row;
- for (int x = 0; x < width; ++x, pixel += 4)
- buffer.setRGBA(x, y, pixel[0], pixel[1], pixel[2], pixel[3]);
+
+ // Do not merge the loops below. They are hand rolled for each case for maximal peformace.
+ ImageFrame::PixelData* dst = buffer.getAddr(0, y);
+ if (buffer.premultiplyAlpha()) {
+ for (int x = 0; x < width; ++x, pixel += 4)
+ buffer.setRGBAPremultiply(dst + x, pixel[0], pixel[1], pixel[2], pixel[3]);
+ } else {
+ for (int x = 0; x < width; ++x, pixel += 4)
+ buffer.setRGBANoPremultiply(dst + x, pixel[0], pixel[1], pixel[2], pixel[3]);
+ }
}
m_decodedHeight = decodedHeight;

Powered by Google App Engine
This is Rietveld 408576698