tools/telemetry/telemetry/page/page_set.py - Issue 15463003: [Telemetry] Utilize CreatePageSet for benchmarks with one page set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_set.py

Issue 15463003: [Telemetry] Utilize CreatePageSet for benchmarks with one page set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make file_path required Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_set.py

diff --git a/tools/telemetry/telemetry/page/page_set.py b/tools/telemetry/telemetry/page/page_set.py

index c564d5a88f2c61d52d4ef2113adaa2715fd0bdca..a69f260bbdb1e4d08d83762f944e5b3cdd928df4 100644

--- a/tools/telemetry/telemetry/page/page_set.py

+++ b/tools/telemetry/telemetry/page/page_set.py

@@ -38,7 +38,7 @@ class PageSet(object):

return cls.FromDict(data, file_path)

@classmethod

- def FromDict(cls, data, file_path=''):

+ def FromDict(cls, data, file_path):

page_set = cls(file_path, data)

for page_attributes in data['pages']:

url = page_attributes.pop('url')