Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5788)

Unified Diff: chrome/browser/thumbnails/thumbnailing_context.h

Issue 15458003: Plugs in the new thumbnailing algorithm to ThumbnailTabHelper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added unit tests. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/thumbnails/thumbnailing_context.h
diff --git a/chrome/browser/thumbnails/thumbnailing_context.h b/chrome/browser/thumbnails/thumbnailing_context.h
index 41735606244fedc79215dfb521712e841efaed98..8fc5db17c4d87bd4d2ac7dafc65a42b3a8c73979 100644
--- a/chrome/browser/thumbnails/thumbnailing_context.h
+++ b/chrome/browser/thumbnails/thumbnailing_context.h
@@ -10,6 +10,8 @@
#include "chrome/browser/thumbnails/thumbnail_service.h"
#include "chrome/common/thumbnail_score.h"
#include "content/public/browser/web_contents.h"
+#include "ui/base/layout.h"
mazda 2013/05/23 19:13:57 Is this needed?
motek. 2013/05/27 16:54:54 layout? Not anymore, my bad. Sorry for the sloppin
+#include "ui/gfx/size.h"
namespace thumbnails {
@@ -28,6 +30,8 @@ enum ClipResult {
CLIP_RESULT_TALLER_THAN_WIDE,
// The source and destination aspect ratios are identical.
CLIP_RESULT_NOT_CLIPPED,
+ // The source and destination are identical.
+ CLIP_RESULT_SOURCE_SAME_AS_TARGET
mazda 2013/05/23 19:13:57 nit: add "," at the end
motek. 2013/05/27 16:54:54 Done.
};
// Holds the information needed for processing a thumbnail.
@@ -39,10 +43,13 @@ struct ThumbnailingContext : base::RefCountedThreadSafe<ThumbnailingContext> {
scoped_refptr<ThumbnailService> service;
GURL url;
ClipResult clip_result;
+ gfx::Size requested_copy_size;
ThumbnailScore score;
- private:
+ protected:
+ ThumbnailingContext() { } // Introduced as a test seam only.
mazda 2013/05/23 19:13:57 I don't think inheritance is necessary. Why don't
motek. 2013/05/27 16:54:54 Good idea. Done.
~ThumbnailingContext();
+
friend class base::RefCountedThreadSafe<ThumbnailingContext>;
};

Powered by Google App Engine
This is Rietveld 408576698