chrome/browser/thumbnails/thumbnail_service_impl.h - Issue 15458003: Plugs in the new thumbnailing algorithm to ThumbnailTabHelper.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/thumbnails/thumbnail_service_impl.h

Issue 15458003: Plugs in the new thumbnailing algorithm to ThumbnailTabHelper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added unit tests. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/thumbnails/advanced_thumbnail_crop_unittest.cc ('K') | « chrome/browser/thumbnails/simple_thumbnail_crop_unittest.cc ('k') | chrome/browser/thumbnails/thumbnail_service_impl.cc » ('j') | chrome/browser/thumbnails/thumbnailing_context.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_THUMBNAILS_THUMBNAIL_SERVICE_IMPL_H_	5 #ifndef CHROME_BROWSER_THUMBNAILS_THUMBNAIL_SERVICE_IMPL_H_

6 #define CHROME_BROWSER_THUMBNAILS_THUMBNAIL_SERVICE_IMPL_H_	6 #define CHROME_BROWSER_THUMBNAILS_THUMBNAIL_SERVICE_IMPL_H_

7	7

8 #include "base/memory/ref_counted.h"	8 #include "base/memory/ref_counted.h"

9 #include "chrome/browser/history/top_sites.h"	9 #include "chrome/browser/history/top_sites.h"

10 #include "chrome/browser/profiles/profile.h"	10 #include "chrome/browser/profiles/profile.h"

(...skipping 19 matching lines...) Expand all Loading...
30 const GURL& url,	30 const GURL& url,

31 scoped_refptr<base::RefCountedMemory>* bytes) OVERRIDE;	31 scoped_refptr<base::RefCountedMemory>* bytes) OVERRIDE;

32 virtual bool ShouldAcquirePageThumbnail(const GURL& url) OVERRIDE;	32 virtual bool ShouldAcquirePageThumbnail(const GURL& url) OVERRIDE;

33	33

34 // Implementation of RefcountedProfileKeyedService.	34 // Implementation of RefcountedProfileKeyedService.

35 virtual void ShutdownOnUIThread() OVERRIDE;	35 virtual void ShutdownOnUIThread() OVERRIDE;

36	36

37 private:	37 private:

38 virtual ~ThumbnailServiceImpl();	38 virtual ~ThumbnailServiceImpl();

39	39

	40 // True if thumbnail retargetting feature is enabled (Finch/flags).

	41 static bool GetThumbnailRetargettingEnabled();
	mazda 2013/05/23 19:13:57 Because this is used only in .cc, how about hiding Because this is used only in .cc, how about hiding this in .cc? Also I prefer the name IsThumbnailRetargettingEnabled. motek. 2013/05/27 16:54:54 Done. Show quoted text On 2013/05/23 19:13:57, mazda wrote: > Because this is used only in .cc, how about hiding this in .cc? > Also I prefer the name IsThumbnailRetargettingEnabled. Done.
	42

40 scoped_refptr<history::TopSites> top_sites_;	43 scoped_refptr<history::TopSites> top_sites_;

	44 bool use_thumbnail_retargetting_;

41	45

42 DISALLOW_COPY_AND_ASSIGN(ThumbnailServiceImpl);	46 DISALLOW_COPY_AND_ASSIGN(ThumbnailServiceImpl);

43 };	47 };

44	48

45 }	49 }

46	50

47 #endif // CHROME_BROWSER_THUMBNAILS_THUMBNAIL_SERVICE_IMPL_H_	51 #endif // CHROME_BROWSER_THUMBNAILS_THUMBNAIL_SERVICE_IMPL_H_

OLD	NEW