Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Issue 15435003: cc: Add CopyAsBitmapRequest class to hold the readback callback. (Closed)

Created:
7 years, 7 months ago by danakj
Modified:
7 years, 7 months ago
Reviewers:
danakj, piman
CC:
chromium-reviews, cc-bugs_chromium.org, backer
Visibility:
Public.

Description

cc: Add CopyAsBitmapRequest class to hold the readback callback. Currently when you request an async copy of a layer as a bitmap, we pass around the raw base::Callback. In order to add functionality to the copy/readback mechanism, we need to pass along other parameters such as a size to scale the copy to. Instead of passing along an ever-growing list of parameters, wrap the base::Callback in a class called CopyAsBitmapRequest. Then new parameters can be added to this class. No change in behaviour here, covered by existing tests. R=piman BUG=242571 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201990

Patch Set 1 : #

Patch Set 2 : scoped_ptr CopyOutputReqest #

Patch Set 3 : Fix scoped_ptr_vector and add test #

Patch Set 4 : nolint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -138 lines) Patch
M cc/base/scoped_ptr_vector.h View 1 2 3 2 chunks +12 lines, -1 line 0 comments Download
A cc/base/scoped_ptr_vector_unittest.cc View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/layer.h View 1 5 chunks +9 lines, -12 lines 0 comments Download
M cc/layers/layer.cc View 1 5 chunks +27 lines, -24 lines 0 comments Download
M cc/layers/layer_impl.h View 1 3 chunks +4 lines, -9 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 4 chunks +10 lines, -18 lines 0 comments Download
A cc/output/copy_output_request.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A cc/output/copy_output_request.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download
M cc/output/direct_renderer.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M cc/output/direct_renderer.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
M cc/output/gl_renderer.h View 1 4 chunks +5 lines, -4 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 9 chunks +21 lines, -23 lines 0 comments Download
M cc/output/software_renderer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/output/software_renderer.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M cc/quads/render_pass.h View 1 3 chunks +2 lines, -4 lines 0 comments Download
M cc/quads/render_pass.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/quads/render_pass_unittest.cc View 1 2 4 chunks +8 lines, -4 lines 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M cc/test/pixel_test.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 4 chunks +21 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
7 years, 7 months ago (2013-05-21 19:58:56 UTC) #1
piman
lgtm
7 years, 7 months ago (2013-05-21 20:39:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/15435003/2001
7 years, 7 months ago (2013-05-21 20:41:56 UTC) #3
piman
lgtm
7 years, 7 months ago (2013-05-23 21:02:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/15435003/23001
7 years, 7 months ago (2013-05-23 21:23:26 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 06:45:37 UTC) #6
Message was sent while issue was closed.
Change committed as 201990

Powered by Google App Engine
This is Rietveld 408576698