Issue 15419002: views: Store only the name of the class in kViewClassName constants.

Issue 15419002: views: Store only the name of the class in kViewClassName constants. (Closed)

Created:
7 years, 7 months ago by tfarina

Modified:
7 years, 7 months ago

Reviewers:
James Cook, sky

CC:
chromium-reviews, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Store only the name of the class in kViewClassName constants. BUG=235984 R=jamescook@chromium.org,sky@chromium.org NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202355

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -15 lines)			Patch
M	ui/views/controls/button/checkbox.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/button/custom_button.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/button/label_button.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/button/menu_button.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/button/radio_button.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/button/text_button.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/views/controls/combobox/combobox.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/label.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/menu/menu_item_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/menu/submenu_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/native/native_view_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/textfield/textfield.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/root_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tfarina

Kind of boring review, I know. Sorry. Please, take a look. Thanks.

7 years, 7 months ago (2013-05-19 15:32:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/15419002/1

7 years, 7 months ago (2013-05-26 23:36:00 UTC) #4

Message was sent while issue was closed.

Change committed as 202355

Expand Messages | Collapse Messages