Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Side by Side Diff: Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py

Issue 15416008: Remove a bunch of dead code from webkitpy (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # Copyright (c) 2010 Google Inc. All rights reserved.
2 #
3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are
5 # met:
6 #
7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer
11 # in the documentation and/or other materials provided with the
12 # distribution.
13 # * Neither the name of Google Inc. nor the names of its
14 # contributors may be used to endorse or promote products derived from
15 # this software without specific prior written permission.
16 #
17 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
18 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
19 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
20 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
21 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
22 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
23 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28
29 from webkitpy.tool.bot.patchanalysistask import PatchAnalysisTask, PatchAnalysis TaskDelegate
30
31
32 class CommitQueueTaskDelegate(PatchAnalysisTaskDelegate):
33 def parent_command(self):
34 return "commit-queue"
35
36 def did_pass_testing_ews(self, patch):
37 raise NotImplementedError("subclasses must implement")
38
39
40 class CommitQueueTask(PatchAnalysisTask):
41 def validate(self):
42 # Bugs might get closed, or patches might be obsoleted or r-'d while the
43 # commit-queue is processing.
44 self._patch = self._delegate.refetch_patch(self._patch)
45 if self._patch.is_obsolete():
46 return False
47 if self._patch.bug().is_closed():
48 return False
49 if not self._patch.committer():
50 return False
51 if self._patch.review() == "-":
52 return False
53 return True
54
55 def _validate_changelog(self):
56 return self._run_command([
57 "validate-changelog",
58 "--non-interactive",
59 self._patch.id(),
60 ],
61 "ChangeLog validated",
62 "ChangeLog did not pass validation")
63
64 def _did_pass_tests_recently(self):
65 if self._delegate.did_pass_testing_ews(self._patch):
66 return True
67 return self._test_patch()
68
69 def run(self):
70 if not self.validate():
71 return False
72 if not self._clean():
73 return False
74 if not self._update():
75 return False
76 if not self._apply():
77 return self.report_failure()
78 if not self._validate_changelog():
79 return self.report_failure()
80 if not self._patch.is_rollout():
81 if not self._build():
82 if not self._build_without_patch():
83 return False
84 return self.report_failure()
85 if not self._did_pass_tests_recently():
86 return False
87 # Make sure the patch is still valid before landing (e.g., make sure
88 # no one has set commit-queue- since we started working on the patch.)
89 if not self.validate():
90 return False
91 # FIXME: We should understand why the land failure occurred and retry if possible.
92 if not self._land():
93 return self.report_failure()
94 return True
OLDNEW
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698