Refactoring: Make LinkStyle instantiation lazy

Refactoring: Make LinkStyle instantiation lazy

This change makes LinkStyle instantiation lazy so that
we can identify exactly when we need LinkStyle.
In following changes, I'll introduce another Link object
which will be LinkImport. LinkStyle and LinkImport is mutually
exclusive, and linkStyleToProcess() will become kind of
factdory method.

BUG=240592
TEST=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150658

[Hajime Morrita, 2013-05-20 07:17:43]

Could you take a look? This is another safe step.

[eseidel, 2013-05-20 07:56:34]

https://codereview.chromium.org/15415004/diff/1/Source/core/html/HTMLLinkElem...
File Source/core/html/HTMLLinkElement.cpp (right):

https://codereview.chromium.org/15415004/diff/1/Source/core/html/HTMLLinkElem...
Source/core/html/HTMLLinkElement.cpp:108: m_disabled = value;
Why do we need to save the value here?  Doesn't fastGetAttribute(disabledAttr)
give us the same value?

[eseidel, 2013-05-20 07:59:19]

lgtm

Aside from the unneeded disabled storage, this looks fine.

https://codereview.chromium.org/15415004/diff/1/Source/core/html/HTMLLinkElem...
File Source/core/html/HTMLLinkElement.cpp (right):

https://codereview.chromium.org/15415004/diff/1/Source/core/html/HTMLLinkElem...
Source/core/html/HTMLLinkElement.cpp:155: m_link = adoptPtr(new
LinkStyle(this));
LinkStyle::create() is slightly preferred.

[tkent, 2013-05-20 08:06:25]

https://codereview.chromium.org/15415004/diff/1/Source/core/html/HTMLLinkElem...
File Source/core/html/HTMLLinkElement.cpp (right):

https://codereview.chromium.org/15415004/diff/1/Source/core/html/HTMLLinkElem...
Source/core/html/HTMLLinkElement.cpp:108: m_disabled = value;
On 2013/05/20 07:56:34, eseidel wrote:
> Why do we need to save the value here?  Doesn't fastGetAttribute(disabledAttr)
> give us the same value?

I have the same comment.  fastHasAttribute(disabledAttr) should work?

[Hajime Morrita, 2013-05-20 08:09:11]

thanks for reviewing, and your comments are right!
It should work. m_disabled seems redundant. I'll update the patch to use it,
then land it.

[commit-bot: I haz the power, 2013-05-20 08:12:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/morrita@chromium.org/15415004/5001

[commit-bot: I haz the power, 2013-05-20 09:13:41]

Change committed as 150658