Prettier "last synced" times on the recent tabs page.

chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsGroupView.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.ntp;
 
 import android.content.Context;
 import android.content.res.Resources;
 import android.graphics.drawable.LevelListDrawable;
 import android.util.AttributeSet;
 import android.view.View;
 import android.widget.ImageView;
 import android.widget.RelativeLayout;
 import android.widget.TextView;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ntp.ForeignSessionHelper.ForeignSession;
 import org.chromium.chrome.browser.widget.TintedDrawable;
 import org.chromium.ui.base.DeviceFormFactor;
 
-import java.util.concurrent.TimeUnit;
-
 /**
  * Header view shown above each group of items on the Recent Tabs page. Shows the name of the
  * group (e.g. "Recently closed" or "Jim's Laptop"), an icon, last synced time, and a button to
  * expand or collapse the group.
  */
 public class RecentTabsGroupView extends RelativeLayout {
 
     /** Drawable levels for the device type icon and the expand/collapse arrow. */
     private static final int DRAWABLE_LEVEL_COLLAPSED = 0;
     private static final int DRAWABLE_LEVEL_EXPANDED = 1;
 
     private ImageView mDeviceIcon;
     private ImageView mExpandCollapseIcon;
     private TextView mDeviceLabel;
     private TextView mTimeLabel;
-    private long mInitializationTimestamp;
     private int mDeviceLabelExpandedColor;
     private int mDeviceLabelCollapsedColor;
     private int mTimeLabelExpandedColor;
     private int mTimeLabelCollapsedColor;
 
     /**
      * Constructor for inflating from XML.
      *
      * @param context The context this view will work in.
      * @param attrs The attribute set for this view.
@@ skipping 24 matching lines @@
                 TintedDrawable.constructTintedDrawable(getResources(), R.drawable.ic_expanded));
         TintedDrawable collapse =
                 TintedDrawable.constructTintedDrawable(getResources(), R.drawable.ic_collapsed);
         collapse.setTint(
                 ApiCompatibilityUtils.getColorStateList(getResources(), R.color.blue_mode_tint));
         collapseIcon.addLevel(DRAWABLE_LEVEL_EXPANDED, DRAWABLE_LEVEL_EXPANDED, collapse);
         mExpandCollapseIcon.setImageDrawable(collapseIcon);
     }
 
     /**
-     * Initialize the state of the group view. Should be called immediatly after object creation.
-     *
-     * @param initializationTimestamp The timestamp to compute the time since last session sync.
-     */
-    public void initialize(long initializationTimestamp) {
-        mInitializationTimestamp = initializationTimestamp;
-    }
-
-    /**
      * Configures the view for currently open tabs.
      *
      * @param isExpanded Whether the view is expanded or collapsed.
      */
     public void configureForCurrentlyOpenTabs(boolean isExpanded) {
         mDeviceIcon.setVisibility(View.VISIBLE);
         mDeviceIcon.setImageResource(DeviceFormFactor.isTablet(getContext())
                 ? R.drawable.recent_tablet : R.drawable.recent_phone);
         String title = getResources().getString(R.string.recent_tabs_this_device);
         mDeviceLabel.setText(title);
@@ skipping 61 matching lines @@
         int level = isExpanded ? DRAWABLE_LEVEL_EXPANDED : DRAWABLE_LEVEL_COLLAPSED;
         mExpandCollapseIcon.getDrawable().setLevel(level);
         mDeviceIcon.setActivated(isExpanded);
 
         mDeviceLabel.setTextColor(isExpanded
                 ? mDeviceLabelExpandedColor
                 : mDeviceLabelCollapsedColor);
         mTimeLabel.setTextColor(isExpanded ? mTimeLabelExpandedColor : mTimeLabelCollapsedColor);
     }
 
-    private String getTimeString(ForeignSession session) {
-        long sessionModifiedTimeSeconds =
-                TimeUnit.SECONDS.convert(session.modifiedTime, TimeUnit.MILLISECONDS);
-        long timeDelta = mInitializationTimestamp - sessionModifiedTimeSeconds;
-        timeDelta = timeDelta > 0 ? timeDelta : 0;
+    private CharSequence getTimeString(ForeignSession session) {
+        long timeDeltaMs = System.currentTimeMillis() - session.modifiedTime;
+        if (timeDeltaMs < 0) timeDeltaMs = 0;
 
-        long daysElapsed = timeDelta / (24L * 60L * 60L);
-        long hoursElapsed = timeDelta / (60L * 60L);
-        long minutesElapsed = timeDelta / 60L;
+        int daysElapsed = (int) (timeDeltaMs / (24L * 60L * 60L * 1000L));
+        int hoursElapsed = (int) (timeDeltaMs / (60L * 60L * 1000L));
+        int minutesElapsed = (int) (timeDeltaMs / (60L * 1000L));
 
-        Resources resources = getContext().getResources();
+        Resources res = getResources();
+        String relativeTime;
         if (daysElapsed > 0L) {
-            return resources.getString(R.string.ntp_recent_tabs_last_synced_days, daysElapsed);
+            relativeTime = res.getQuantityString(R.plurals.n_days_ago, daysElapsed, daysElapsed);
         } else if (hoursElapsed > 0L) {
-            return resources.getString(R.string.ntp_recent_tabs_last_synced_hours, hoursElapsed);
+            relativeTime = res.getQuantityString(R.plurals.n_hours_ago, hoursElapsed, hoursElapsed);
         } else if (minutesElapsed > 0L) {
-            return resources.getString(
-                    R.string.ntp_recent_tabs_last_synced_minutes, minutesElapsed);
+            relativeTime = res.getQuantityString(R.plurals.n_minutes_ago, minutesElapsed,
+                    minutesElapsed);

[Ian Wen, 2015/12/21 13:03:44]

Remove the third parameter?

[newt (away), 2015/12/21 16:55:55]

Oddly, the third parameter is required. The second parameter is used to
determine which quantity string to use; the third parameter is inserted into the
quantity string using String.format().

In many cases, the second and third parameter are the same. In some cases, you
might omit the third parameter. E.g. if the quantity strings are "You have a new
message / You have new messages", then you wouldn't need a third parameter,
since there's no "%d" to replace.

         } else {
-            return resources.getString(R.string.ntp_recent_tabs_last_synced_just_now);
+            relativeTime = res.getString(R.string.just_now);
         }
+
+        return getResources().getString(R.string.ntp_recent_tabs_last_synced, relativeTime);
     }
 
     /**
      * Shows or hides the time label (e.g. "Last synced: just now") and adjusts the positions of the
      * icon and device label. In particular, the icon and device label are top-aligned when the time
      * is visible, but are vertically centered when the time is gone.
      */
     private void setTimeLabelVisibility(int visibility) {
         if (mTimeLabel.getVisibility() == visibility) return;
         mTimeLabel.setVisibility(visibility);
         if (visibility == View.GONE) {
             replaceRule(mDeviceIcon, ALIGN_PARENT_TOP, CENTER_VERTICAL);
             replaceRule(mDeviceLabel, ALIGN_PARENT_TOP, CENTER_VERTICAL);
         } else {
             replaceRule(mDeviceIcon, CENTER_VERTICAL, ALIGN_PARENT_TOP);
             replaceRule(mDeviceLabel, CENTER_VERTICAL, ALIGN_PARENT_TOP);
         }
     }
 
     private static void replaceRule(View view, int oldRule, int newRule) {
         RelativeLayout.LayoutParams lp = ((RelativeLayout.LayoutParams) view.getLayoutParams());
         lp.addRule(oldRule, 0);
         lp.addRule(newRule);
     }
 }