Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3340)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 1539763004: Miscellaneous fixes to DataUse UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index 7f514c79c1eecadd170388bf39210410e0bc4053..4661f592510419ab06423748a10e3c29ddd3c481 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -472,18 +472,14 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
if (mTabModelSelectorTabObserver != null) mTabModelSelectorTabObserver.destroy();
mTabModelSelectorTabObserver = new TabModelSelectorTabObserver(tabModelSelector) {
@Override
- public void onPageLoadStarted(Tab tab, String url) {
- if (DataUseTabUIManager.checkDataUseTrackingStarted(tab)) {
+ public void didFirstVisuallyNonEmptyPaint(Tab tab) {
+ if (DataUseTabUIManager.checkAndResetDataUseTrackingStarted(tab)) {
mDataUseSnackbarController.showDataUseTrackingStartedBar();
- } else if (DataUseTabUIManager.checkDataUseTrackingEnded(tab)
- && DataUseTabUIManager
- .getOptedOutOfDataUseDialog(getApplicationContext())) {
+ } else if (DataUseTabUIManager.getOptedOutOfDataUseDialog(getApplicationContext())
+ && DataUseTabUIManager.checkAndResetDataUseTrackingEnded(tab)) {
mDataUseSnackbarController.showDataUseTrackingEndedBar();
}
- }
- @Override
- public void didFirstVisuallyNonEmptyPaint(Tab tab) {
if (!tab.isNativePage() && !tab.isIncognito()
&& DataReductionProxySettings.getInstance().wasLoFiModeActiveOnMainFrame()
&& DataReductionProxySettings.getInstance().canUseDataReductionProxy(
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698