chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java - Issue 1539763004: Miscellaneous fixes to DataUse UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java

Issue 1539763004: Miscellaneous fixes to DataUse UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, addressed megjablon comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java ('k') | chrome/browser/android/data_usage/data_use_tab_helper.h » ('j') | chrome/browser/android/data_usage/data_use_ui_tab_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java

index ffb3a39281fa41037a14966acc383c49e4bbbabb..fc51620feca6f7e1feeda04a53beb18d0619443c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java

@@ -112,10 +112,10 @@ public class ExternalDataUseObserver {

}

@NativeClassQualifiedName("ExternalDataUseObserverBridge")

- public native void nativeFetchMatchingRulesDone(long nativeExternalDataUseObserver,

+ private native void nativeFetchMatchingRulesDone(long nativeExternalDataUseObserver,

String[] appPackageName, String[] domainPathRegEx, String[] label);

@NativeClassQualifiedName("ExternalDataUseObserverBridge")

- public native void nativeOnReportDataUseDone(

+ private native void nativeOnReportDataUseDone(

long nativeExternalDataUseObserver, boolean success);

}