Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 1539763004: Miscellaneous fixes to DataUse UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased, addressed megjablon comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index 9e0d6bcbb052703100b12290e05255718cbceb74..b2773e07f956673aed9ee96af6fe8999fc7f06df 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -468,18 +468,14 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
if (mTabModelSelectorTabObserver != null) mTabModelSelectorTabObserver.destroy();
mTabModelSelectorTabObserver = new TabModelSelectorTabObserver(tabModelSelector) {
@Override
- public void onPageLoadStarted(Tab tab, String url) {
+ public void didFirstVisuallyNonEmptyPaint(Tab tab) {
if (DataUseTabUIManager.checkDataUseTrackingStarted(tab)) {
mDataUseSnackbarController.showDataUseTrackingStartedBar();
- } else if (DataUseTabUIManager.checkDataUseTrackingEnded(tab)
- && DataUseTabUIManager
- .getOptedOutOfDataUseDialog(getApplicationContext())) {
+ } else if (DataUseTabUIManager.getOptedOutOfDataUseDialog(getApplicationContext())
+ && DataUseTabUIManager.checkDataUseTrackingEnded(tab)) {
mDataUseSnackbarController.showDataUseTrackingEndedBar();
}
- }
- @Override
- public void didFirstVisuallyNonEmptyPaint(Tab tab) {
if (!tab.isNativePage() && !tab.isIncognito()
&& DataReductionProxySettings.getInstance().wasLoFiModeActiveOnMainFrame()
&& DataReductionProxySettings.getInstance().canUseDataReductionProxy(

Powered by Google App Engine
This is Rietveld 408576698