Source/core/page/DOMSelection.cpp - Issue 15390003: Use-after-free in WebCore::Range::compareBoundaryPoints

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DOMSelection.cpp

Issue 15390003: Use-after-free in WebCore::Range::compareBoundaryPoints (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Removes unneeded ref to node |n|. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/DOMSelection.cpp

diff --git a/Source/core/page/DOMSelection.cpp b/Source/core/page/DOMSelection.cpp

index ed91368b54e33510b8c38708c047c5e0a8308bde..5e34937743ca3cecffebfda72d6ddc9818624505 100644

--- a/Source/core/page/DOMSelection.cpp

+++ b/Source/core/page/DOMSelection.cpp

@@ -454,10 +454,10 @@ bool DOMSelection::containsNode(const Node* n, bool allowPartial) const

if (!n || m_frame->document() != n->document() || selection->isNone())

return false;

- ContainerNode* parentNode = n->parentNode();

unsigned nodeIndex = n->nodeIndex();

RefPtr<Range> selectedRange = selection->selection().toNormalizedRange();

+ ContainerNode* parentNode = n->parentNode();

if (!parentNode)

return false;

« no previous file with comments | « LayoutTests/editing/selection/contains-node-crash-expected.txt ('k') | no next file » | no next file with comments »