Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 15389003: Loosen a bit the HTML hierarchy required for Tabs to work, Improved UX of the dev tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Introduce RTL, changed non-selected tab color, applied feedback from dbeam. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/apps_debugger/background.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/developer_private/developer_private_api. h" 5 #include "chrome/browser/extensions/api/developer_private/developer_private_api. h"
6 6
7 #include "base/base64.h" 7 #include "base/base64.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/i18n/file_util_icu.h" 10 #include "base/i18n/file_util_icu.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 #include "content/public/browser/render_view_host.h" 42 #include "content/public/browser/render_view_host.h"
43 #include "content/public/browser/storage_partition.h" 43 #include "content/public/browser/storage_partition.h"
44 #include "content/public/browser/web_contents.h" 44 #include "content/public/browser/web_contents.h"
45 #include "extensions/browser/view_type_utils.h" 45 #include "extensions/browser/view_type_utils.h"
46 #include "extensions/common/constants.h" 46 #include "extensions/common/constants.h"
47 #include "extensions/common/extension_resource.h" 47 #include "extensions/common/extension_resource.h"
48 #include "grit/chromium_strings.h" 48 #include "grit/chromium_strings.h"
49 #include "grit/generated_resources.h" 49 #include "grit/generated_resources.h"
50 #include "net/base/net_util.h" 50 #include "net/base/net_util.h"
51 #include "ui/base/l10n/l10n_util.h" 51 #include "ui/base/l10n/l10n_util.h"
52 #include "ui/webui/web_ui_util.h"
52 #include "webkit/blob/shareable_file_reference.h" 53 #include "webkit/blob/shareable_file_reference.h"
53 #include "webkit/fileapi/file_system_context.h" 54 #include "webkit/fileapi/file_system_context.h"
54 #include "webkit/fileapi/file_system_operation.h" 55 #include "webkit/fileapi/file_system_operation.h"
55 #include "webkit/fileapi/local_file_system_operation.h" 56 #include "webkit/fileapi/local_file_system_operation.h"
56 #include "webkit/fileapi/syncable/syncable_file_system_util.h" 57 #include "webkit/fileapi/syncable/syncable_file_system_util.h"
57 58
58 using content::RenderViewHost; 59 using content::RenderViewHost;
59 60
60 namespace extensions { 61 namespace extensions {
61 62
(...skipping 1156 matching lines...) Expand 10 before | Expand all | Expand 10 after
1218 SendResponse(false); 1219 SendResponse(false);
1219 Release(); 1220 Release();
1220 } 1221 }
1221 1222
1222 DeveloperPrivateChoosePathFunction::~DeveloperPrivateChoosePathFunction() {} 1223 DeveloperPrivateChoosePathFunction::~DeveloperPrivateChoosePathFunction() {}
1223 1224
1224 bool DeveloperPrivateGetStringsFunction::RunImpl() { 1225 bool DeveloperPrivateGetStringsFunction::RunImpl() {
1225 DictionaryValue* dict = new DictionaryValue(); 1226 DictionaryValue* dict = new DictionaryValue();
1226 SetResult(dict); 1227 SetResult(dict);
1227 1228
1229 webui::SetFontAndTextDirection(dict);
1230
1228 #define SET_STRING(id, idr) \ 1231 #define SET_STRING(id, idr) \
1229 dict->SetString(id, l10n_util::GetStringUTF16(idr)) 1232 dict->SetString(id, l10n_util::GetStringUTF16(idr))
1230 SET_STRING("extensionSettings", IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE); 1233 SET_STRING("extensionSettings", IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE);
1231 1234
1232 SET_STRING("appsDevtoolSearch", IDS_APPS_DEVTOOL_SEARCH); 1235 SET_STRING("appsDevtoolSearch", IDS_APPS_DEVTOOL_SEARCH);
1233 SET_STRING("appsDevtoolNoApps", IDS_APPS_DEVTOOL_NO_APPS_INSTALLED); 1236 SET_STRING("appsDevtoolNoApps", IDS_APPS_DEVTOOL_NO_APPS_INSTALLED);
1234 SET_STRING("appsDevtoolApps", IDS_APPS_DEVTOOL_APPS_INSTALLED); 1237 SET_STRING("appsDevtoolApps", IDS_APPS_DEVTOOL_APPS_INSTALLED);
1235 SET_STRING("appsDevtoolExtensions", IDS_APPS_DEVTOOL_EXTENSIONS_INSTALLED); 1238 SET_STRING("appsDevtoolExtensions", IDS_APPS_DEVTOOL_EXTENSIONS_INSTALLED);
1236 SET_STRING("appsDevtoolNoExtensions", 1239 SET_STRING("appsDevtoolNoExtensions",
1237 IDS_EXTENSIONS_NONE_INSTALLED); 1240 IDS_EXTENSIONS_NONE_INSTALLED);
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
1297 1300
1298 #undef SET_STRING 1301 #undef SET_STRING
1299 return true; 1302 return true;
1300 } 1303 }
1301 1304
1302 DeveloperPrivateGetStringsFunction::~DeveloperPrivateGetStringsFunction() {} 1305 DeveloperPrivateGetStringsFunction::~DeveloperPrivateGetStringsFunction() {}
1303 1306
1304 } // namespace api 1307 } // namespace api
1305 1308
1306 } // namespace extensions 1309 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/apps_debugger/background.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698