Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 15387004: Remove some unused includes from core/css and core/dom (Closed)

Created:
7 years, 7 months ago by Timothy Loh
Modified:
7 years, 7 months ago
Reviewers:
pdr., eseidel
CC:
blink-reviews, kenneth.christiansen, webcomponents-bugzilla_chromium.org, eae+blinkwatch, dglazkov+blink, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Remove some unused includes from core/css and core/dom Splitting up codereview.chromium.org/15447002 into smaller patches. BUG=242216 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -228 lines) Patch
M Source/core/css/CSSBasicShapes.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSCanvasValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSCursorImageValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSFontFace.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSFontFaceSource.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSFontSelector.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSImageGeneratorValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSImageValue.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSImportRule.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSLineBoxContainValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSMediaRule.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSPageRule.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSParser.cpp View 4 chunks +0 lines, -7 lines 0 comments Download
M Source/core/css/CSSParserValues.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSRuleList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSSegmentedFontFace.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSStyleRule.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSSupportsRule.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSValuePool.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/DeprecatedStyleBuilder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/css/FontFeatureValue.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/MediaList.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/MediaQueryEvaluator.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/css/MediaQueryListListener.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/MediaQueryMatcher.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/PageRuleCollector.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/SVGCSSParser.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/SVGCSSStyleSelector.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/StyleInvalidationAnalysis.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/StyleRuleImport.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/StyleSheetList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/WebKitCSSKeyframesRule.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/WebKitCSSMatrix.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/WebKitCSSShaderValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/TransformBuilder.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/ActiveDOMObject.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Attr.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/ChildListMutationScope.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/ClassNodeList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/ClientRectList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Clipboard.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M Source/core/dom/ContextDestructionObserver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/CustomElementRegistry.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/dom/DecodedDataDocumentParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DocumentEventQueue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DocumentFragment.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/Element.cpp View 4 chunks +0 lines, -10 lines 0 comments Download
M Source/core/dom/Event.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/EventContext.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/EventDispatchMediator.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/EventDispatcher.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/EventListenerMap.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/EventTarget.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/FocusEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/KeyboardEvent.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/dom/MutationObserverInterestGroup.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/MutationObserverRegistration.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/NameNodeList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/NamedNodeMap.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/NodeFilter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Notation.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/ProcessingInstruction.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/Range.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/dom/ScriptElement.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/dom/ScriptableDocumentParser.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/StyleElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Text.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Touch.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/TreeScope.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/TreeScopeAdopter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/UIEvent.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/UserActionElementSet.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/ViewportArguments.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/dom/VisitedLinkState.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/WheelEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/default/chromium/PlatformMessagePortChannelChromium.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/shadow/ComposedShadowTreeWalker.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/shadow/ContentSelectorQuery.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Timothy Loh
7 years, 7 months ago (2013-05-21 05:30:36 UTC) #1
pdr.
On 2013/05/21 05:30:36, Timothy Loh wrote: rs=me, LGTM
7 years, 7 months ago (2013-05-21 05:47:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/15387004/1
7 years, 7 months ago (2013-05-21 05:48:37 UTC) #3
eseidel
Did we decide this made the build faster and thus was worth it?
7 years, 7 months ago (2013-05-21 06:05:42 UTC) #4
eseidel
Landing these will make it harder to land changes which remove includes from headers, no?
7 years, 7 months ago (2013-05-21 06:07:04 UTC) #5
pdr.
On 2013/05/21 06:07:04, eseidel wrote: > Landing these will make it harder to land changes ...
7 years, 7 months ago (2013-05-21 06:10:04 UTC) #6
Timothy Loh
> Did we decide this made the build faster and thus was worth it? The ...
7 years, 7 months ago (2013-05-21 06:12:30 UTC) #7
commit-bot: I haz the power
List of reviewers changed. eseidel@chromium.org did a drive-by without LGTM'ing!
7 years, 7 months ago (2013-05-21 06:33:51 UTC) #8
eseidel
lgtm
7 years, 7 months ago (2013-05-21 06:39:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/15387004/1
7 years, 7 months ago (2013-05-21 06:41:37 UTC) #10
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 06:42:45 UTC) #11
Message was sent while issue was closed.
Change committed as 150748

Powered by Google App Engine
This is Rietveld 408576698