Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1538473002: Revert "Add debug loggings to figure out a snackbar crash" (Closed)

Created:
5 years ago by Ian Wen
Modified:
4 years, 12 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add debug loggings to figure out a snackbar crash" This reverts commit 83557154975fb266458aa974a0e8c5e02fd57f8c. BUG=553569 Committed: https://crrev.com/a352d7c482891dd488302b06e87929b14877c7dc Cr-Commit-Position: refs/heads/master@{#367049}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -58 lines) Patch
M chrome/android/java/res/layout/snackbar.xml View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java View 7 chunks +5 lines, -53 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Ian Wen
PTAL. The bug is fixed so the loggings should be removed.
4 years, 12 months ago (2015-12-28 08:59:57 UTC) #2
gone
lgtm
4 years, 12 months ago (2015-12-28 18:39:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538473002/20001
4 years, 12 months ago (2015-12-29 03:39:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 12 months ago (2015-12-29 04:17:27 UTC) #7
commit-bot: I haz the power
4 years, 12 months ago (2015-12-29 04:19:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a352d7c482891dd488302b06e87929b14877c7dc
Cr-Commit-Position: refs/heads/master@{#367049}

Powered by Google App Engine
This is Rietveld 408576698