Rename switch to disable prefixed Encrypted Media APIs.

Rename switch to disable prefixed Encrypted Media APIs.

This will allow the prefixed and unprefixed versions to be controlled independently.
The new unprefixed enable switch and flag are also added, though they currently
have no effect.

Both switches are moved from media_switches to content_switches (the reason
reason the switch was moved no longer applies), and the method for disabling on
Android is changed from the switch to the runtime check.

BUG=224791
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203511

[ddorwin, 2013-05-18 00:46:00]

This can land after https://codereview.chromium.org/15016009/.

[xhwang, 2013-05-20 16:59:50]

https://codereview.chromium.org/15383003/diff/6001/chrome/app/generated_resou...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/15383003/diff/6001/chrome/app/generated_resou...
chrome/app/generated_resources.grd:6706: +      <message
name="IDS_FLAGS_ENABLE_ENCRYPTED_MEDIA_NAME" desc="Title for the flag to enable
the unprefixed Encrypted Media Extensions (e.g. webkitGenerateKeyRequest()).">
Shouldn't this be an example of "unprefixed" EME? Drop "webkit"?

https://codereview.chromium.org/15383003/diff/6001/chrome/app/generated_resou...
chrome/app/generated_resources.grd:6716: +        Disable the experimental
version (v0.1b) of the Encrypted Media Extensions.
We have three ways to express the same comcept:
- Encrypted Media Extensions APIs,
- Encrypted Media Extensions,
- Encrypted Media API.

Can we unify them?

Also, we have "prefixed" and "experimental version (v0.1b)" EME API, which is
also a bit confusing.

https://codereview.chromium.org/15383003/diff/6001/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/chrome_restart_request.cc (right):

https://codereview.chromium.org/15383003/diff/6001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/chrome_restart_request.cc:86:
::switches::kDisableWebKitMediaSource,
Is this something left over in acolwell@'s CL?

[ddorwin, 2013-05-20 18:12:17]

I improved the strings. PTAL. Reitveld doesn't allow side-by-side because the
file is too large. :(

https://codereview.chromium.org/15383003/diff/6001/chrome/app/generated_resou...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/15383003/diff/6001/chrome/app/generated_resou...
chrome/app/generated_resources.grd:6706: +      <message
name="IDS_FLAGS_ENABLE_ENCRYPTED_MEDIA_NAME" desc="Title for the flag to enable
the unprefixed Encrypted Media Extensions (e.g. webkitGenerateKeyRequest()).">
On 2013/05/20 16:59:51, xhwang wrote:
> Shouldn't this be an example of "unprefixed" EME? Drop "webkit"?

Done. Thanks.

https://codereview.chromium.org/15383003/diff/6001/chrome/app/generated_resou...
chrome/app/generated_resources.grd:6716: +        Disable the experimental
version (v0.1b) of the Encrypted Media Extensions.
On 2013/05/20 16:59:51, xhwang wrote:
> We have three ways to express the same comcept:
> - Encrypted Media Extensions APIs,
> - Encrypted Media Extensions,
> - Encrypted Media API.
> 
> Can we unify them?
> 
> Also, we have "prefixed" and "experimental version (v0.1b)" EME API, which is
> also a bit confusing.

I tried to clean this up. I say things a little differently in the description
to provide more information (i.e. "experimental"). I eliminated "API" everywhere
except the non-user-visible description.

https://codereview.chromium.org/15383003/diff/6001/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/chrome_restart_request.cc (right):

https://codereview.chromium.org/15383003/diff/6001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/chrome_restart_request.cc:86:
::switches::kDisableWebKitMediaSource,
On 2013/05/20 16:59:51, xhwang wrote:
> Is this something left over in acolwell@'s CL?

This is his switch, but he didn't add it here. I'm just adding it for him. This
list affects which switches can be copied to Guest mode and maybe some other
stuff on Chrome OS.

[xhwang, 2013-05-20 18:57:10]

lgtm % a nit and a question

https://codereview.chromium.org/15383003/diff/10001/chrome/app/generated_reso...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/15383003/diff/10001/chrome/app/generated_reso...
chrome/app/generated_resources.grd:6706: +      <message
name="IDS_FLAGS_ENABLE_ENCRYPTED_MEDIA_NAME" desc="Title for the flag to enable
the unprefixed Encrypted Media Extensions (e.g. MediaKeys).">
nit: Do you want "APIs" after "EME"? Not a big deal, just trying to be
consistent with the "prefixed Encrypted Media Extensions APIs" below.

Also, just OOC, what's the plan to drop "unprefixed"? When we drop the
"prefixed" version of the flags?

[ddorwin, 2013-05-20 22:09:32]

darin, please do an OWNERS review of chrome/ and content/. This is similar to
https://codereview.chromium.org/14582024/.

https://codereview.chromium.org/15383003/diff/10001/chrome/app/generated_reso...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/15383003/diff/10001/chrome/app/generated_reso...
chrome/app/generated_resources.grd:6706: +      <message
name="IDS_FLAGS_ENABLE_ENCRYPTED_MEDIA_NAME" desc="Title for the flag to enable
the unprefixed Encrypted Media Extensions (e.g. MediaKeys).">
On 2013/05/20 18:57:10, xhwang wrote:
> nit: Do you want "APIs" after "EME"? Not a big deal, just trying to be
> consistent with the "prefixed Encrypted Media Extensions APIs" below.

Done
> 
> Also, just OOC, what's the plan to drop "unprefixed"? When we drop the
> "prefixed" version of the flags?

Yes. It's only in a comment, so it won't affect translations.

[ddorwin, 2013-05-22 23:42:28]

darin, please provide OWNERS approval for the minor mostly mechanical changes in
files 3-9.

(The rest have * owners or are owned by the media team.)

[xhwang, 2013-05-31 00:05:00]

We probably need to do the same for EME after this CL is landed:
https://codereview.chromium.org/15679014

[ddorwin, 2013-05-31 18:58:52]

avi, please OWNERS approve content/
zel, please OWNERS approve
chrome/browser/chromeos/login/chrome_restart_request.cc
yfriedman, please OWNERS approve chrome/browser/android/chrome_startup_flags.cc
(logic moved to render_thread_impl.cc)

[zel, 2013-05-31 19:02:04]

LGTM

for chrome/browser/chromeos/*

[Avi (use Gerrit), 2013-05-31 19:11:09]

content lgtm

[Yaron, 2013-05-31 20:10:41]

lgtm

[commit-bot: I haz the power, 2013-05-31 20:18:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ddorwin@chromium.org/15383003/37001

[commit-bot: I haz the power, 2013-05-31 23:56:49]

Change committed as 203511