Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1945)

Unified Diff: appengine/cmd/dm/mutate/finish_attempt_test.go

Issue 1537883002: Initial distributor implementation (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: fix imports and make dummy.go a real file Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/cmd/dm/mutate/finish_attempt.go ('k') | appengine/cmd/dm/mutate/finish_execution.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/cmd/dm/mutate/finish_attempt_test.go
diff --git a/appengine/cmd/dm/mutate/finish_attempt_test.go b/appengine/cmd/dm/mutate/finish_attempt_test.go
index 0ca1919cf52144bffb858b1b27fff90a8720f680..f0f026e264866d0479d7b4bdf12a2657a6952968 100644
--- a/appengine/cmd/dm/mutate/finish_attempt_test.go
+++ b/appengine/cmd/dm/mutate/finish_attempt_test.go
@@ -11,7 +11,7 @@ import (
"github.com/luci/gae/impl/memory"
"github.com/luci/gae/service/datastore"
"github.com/luci/luci-go/appengine/cmd/dm/model"
- "github.com/luci/luci-go/appengine/tumble"
+ //"github.com/luci/luci-go/appengine/tumble"
"github.com/luci/luci-go/common/api/dm/service/v1"
"github.com/luci/luci-go/common/clock/testclock"
. "github.com/luci/luci-go/common/testing/assertions"
@@ -55,12 +55,10 @@ func TestFinishAttempt(t *testing.T) {
Convey("Good", func() {
muts, err := fa.RollForward(c)
So(err, ShouldBeNil)
- So(muts, ShouldResemble, []tumble.Mutation{
- &RecordCompletion{For: &a.ID}})
+ So(muts, ShouldBeEmpty)
So(ds.Get(a, e, ar), ShouldBeNil)
So(e.Token, ShouldBeEmpty)
- So(a.State, ShouldEqual, dm.Attempt_FINISHED)
So(a.ResultExpiration, ShouldResemble,
testclock.TestTimeUTC.Round(time.Microsecond))
So(ar.Data, ShouldResemble, `{"result": true}`)
@@ -69,7 +67,7 @@ func TestFinishAttempt(t *testing.T) {
Convey("Bad ExecutionKey", func() {
fa.Auth.Token = []byte("wat")
_, err := fa.RollForward(c)
- So(err, ShouldBeRPCUnauthenticated, "execution Auth")
+ So(err, ShouldBeRPCPermissionDenied, "execution Auth")
So(ds.Get(a, e), ShouldBeNil)
So(e.Token, ShouldNotBeEmpty)
« no previous file with comments | « appengine/cmd/dm/mutate/finish_attempt.go ('k') | appengine/cmd/dm/mutate/finish_execution.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698