common/gcloud/pubsub/topic.go - Issue 1537883002: Initial distributor implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: common/gcloud/pubsub/topic.go

Issue 1537883002: Initial distributor implementation (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Fix comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: common/gcloud/pubsub/topic.go

diff --git a/common/gcloud/pubsub/topic.go b/common/gcloud/pubsub/topic.go

index 15a267b21517d169639f82b6691b860cef427710..5c9e9f124d74da4bed8c30d08511a85e7a4c455f 100644

--- a/common/gcloud/pubsub/topic.go

+++ b/common/gcloud/pubsub/topic.go

@@ -13,7 +13,7 @@ type Topic string

var _ flag.Value = (*Topic)(nil)

-// NewTopic generates a new Subscritpion for a given project and topic name.

dnj (Google) 2016/06/16 16:57:22 I like how this was the wrong word, and it was als

iannucci 2016/06/18 01:35:41 :D

+// NewTopic generates a new Topic for a given project and topic name.

func NewTopic(project, name string) Topic {

return Topic(newResource(project, "topics", name))

}