common/api/dm/service/v1/execution_state_evolve_test.go - Issue 1537883002: Initial distributor implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: common/api/dm/service/v1/execution_state_evolve_test.go

Issue 1537883002: Initial distributor implementation (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: self review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/cmd/dm/mutate/timeout_execution.go ('K') | « common/api/dm/service/v1/execution_state_evolve.go ('k') | common/api/dm/service/v1/finish_attempt.pb.go » ('j') | common/api/dm/service/v1/graph_data.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: common/api/dm/service/v1/execution_state_evolve_test.go

diff --git a/common/api/dm/service/v1/execution_state_evolve_test.go b/common/api/dm/service/v1/execution_state_evolve_test.go

index c3a4049c446a82240e3bb59d1e3670192fc8b2b3..3b925dc932975e7d371dad9441a8a1a14270f113 100644

--- a/common/api/dm/service/v1/execution_state_evolve_test.go

+++ b/common/api/dm/service/v1/execution_state_evolve_test.go

@@ -16,32 +16,32 @@ func TestExecutionState(t *testing.T) {

Convey("Evolve", t, func() {

Convey("Identity", func() {

- s := Execution_SCHEDULED

- So(s.Evolve(Execution_SCHEDULED), ShouldBeNil)

- So(s, ShouldEqual, Execution_SCHEDULED)

+ s := Execution_SCHEDULING

+ So(s.Evolve(Execution_SCHEDULING), ShouldBeNil)

+ So(s, ShouldEqual, Execution_SCHEDULING)

})

Convey("Transition", func() {

s := Execution_RUNNING

- So(s.Evolve(Execution_FINISHED), ShouldBeNil)

- So(s, ShouldEqual, Execution_FINISHED)

+ So(s.Evolve(Execution_STOPPING), ShouldBeNil)

+ So(s, ShouldEqual, Execution_STOPPING)

})

Convey("Invalid starting transistion", func() {

s := Execution_FINISHED

- So(s.Evolve(Execution_SCHEDULED), ShouldErrLike, "invalid state transition FINISHED -> SCHEDULE")

+ So(s.Evolve(Execution_SCHEDULING), ShouldErrLike, "invalid state transition FINISHED -> SCHEDULING")

So(s, ShouldEqual, Execution_FINISHED)

})

Convey("Invalid ending transistion", func() {

s := Execution_RUNNING

- So(s.Evolve(Execution_SCHEDULED), ShouldErrLike, "invalid state transition RUNNING -> SCHEDULED")

+ So(s.Evolve(Execution_SCHEDULING), ShouldErrLike, "invalid state transition RUNNING -> SCHEDULING")

So(s, ShouldEqual, Execution_RUNNING)

})

Convey("MustEvolve", func() {

s := Execution_FINISHED

- So(func() { s.MustEvolve(Execution_SCHEDULED) }, ShouldPanic)

+ So(func() { s.MustEvolve(Execution_SCHEDULING) }, ShouldPanic)

})

}