appengine/cmd/dm/mutate/add_backdep.go - Issue 1537883002: Initial distributor implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/cmd/dm/mutate/add_backdep.go

Issue 1537883002: Initial distributor implementation (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: self review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/cmd/dm/mutate/add_backdep.go

diff --git a/appengine/cmd/dm/mutate/add_backdep.go b/appengine/cmd/dm/mutate/add_backdep.go

index 2274a4d28178256280351c4e94a146339b7250f6..c86faab422570b1fee94a0b1cd2715e90c8b4e1d 100644

--- a/appengine/cmd/dm/mutate/add_backdep.go

+++ b/appengine/cmd/dm/mutate/add_backdep.go

@@ -43,11 +43,8 @@ func (a *AddBackDep) RollForward(c context.Context) (muts []tumble.Mutation, err

err = ds.Put(bd)

- if a.NeedsAck {

- muts = append(muts, &AckFwdDep{

- Dep: a.Dep,

- DepIsFinished: bdg.AttemptFinished,

- })

+ if a.NeedsAck && bdg.AttemptFinished {

+ muts = append(muts, &AckFwdDep{a.Dep})

}

return

}