Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1676)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: appengine/cmd/dm/deps/walk_graph_test.go

Issue 1537883002: Initial distributor implementation (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: self review Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« appengine/cmd/dm/deps/walk_graph.go ('K') | « appengine/cmd/dm/deps/walk_graph.go ('k') | appengine/cmd/dm/distributor/config.go » ('j') | appengine/cmd/dm/distributor/distributor.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/cmd/dm/deps/walk_graph_test.go
diff --git a/appengine/cmd/dm/deps/walk_graph_test.go b/appengine/cmd/dm/deps/walk_graph_test.go
index acd70a2f766041e2ae7a27cc875c29d6dcb2c0c5..6422522122456d884ad713f2272567b895654b8e 100644
--- a/appengine/cmd/dm/deps/walk_graph_test.go
+++ b/appengine/cmd/dm/deps/walk_graph_test.go
@@ -10,8 +10,9 @@ import (
"time"
"github.com/luci/gae/service/datastore"
+ "github.com/luci/luci-go/appengine/cmd/dm/distributor"
+ "github.com/luci/luci-go/appengine/cmd/dm/distributor/fake"
"github.com/luci/luci-go/appengine/cmd/dm/model"
- "github.com/luci/luci-go/appengine/tumble"
dm "github.com/luci/luci-go/common/api/dm/service/v1"
"github.com/luci/luci-go/common/clock"
"github.com/luci/luci-go/common/clock/testclock"
@@ -37,11 +38,9 @@ func TestWalkGraph(t *testing.T) {
t.Parallel()
Convey("WalkGraph", t, func() {
- ttest := &tumble.Testing{}
- c := ttest.Context()
+ ttest, c, dist, s := testSetup()
ds := datastore.Get(c)
- s := newDecoratedDeps()
req := &dm.WalkGraphReq{
Query: dm.AttemptListQueryL(map[string][]uint32{"quest": {1}}),
@@ -50,7 +49,7 @@ func TestWalkGraph(t *testing.T) {
So(req.Normalize(), ShouldBeNil)
Convey("no attempt", func() {
- So(req, WalkShouldReturn(c), &dm.GraphData{
+ So(req, fake.WalkShouldReturn(c, s), &dm.GraphData{
Quests: map[string]*dm.Quest{"quest": {
Attempts: map[uint32]*dm.Attempt{
1: {DNE: true},
@@ -62,19 +61,15 @@ func TestWalkGraph(t *testing.T) {
Convey("good", func() {
ds.Testable().Consistent(true)
- wDesc := &dm.Quest_Desc{
- DistributorConfigName: "foof",
- JsonPayload: `{"name":"w"}`,
- }
- w := ensureQuest(c, "w", 1)
+ wDesc := fake.QuestDesc("w")
+ w := s.ensureQuest(c, "w", 1)
ttest.Drain(c)
- aid := dm.NewAttemptID(w, 1)
req.Query.AttemptList = dm.NewAttemptList(
map[string][]uint32{w: {1}})
Convey("include nothing", func() {
- So(req, WalkShouldReturn(c), &dm.GraphData{
+ So(req, fake.WalkShouldReturn(c, s), &dm.GraphData{
Quests: map[string]*dm.Quest{
w: {
Attempts: map[uint32]*dm.Attempt{1: {}},
@@ -88,7 +83,7 @@ func TestWalkGraph(t *testing.T) {
req.Limit.MaxDepth = 1
req.Query.AttemptList = dm.NewAttemptList(
map[string][]uint32{"noex": {1}})
- So(req, WalkShouldReturn(c), &dm.GraphData{
+ So(req, fake.WalkShouldReturn(c, s), &dm.GraphData{
Quests: map[string]*dm.Quest{
"noex": {
DNE: true,
@@ -102,46 +97,55 @@ func TestWalkGraph(t *testing.T) {
req.Include.AttemptData = true
req.Include.QuestData = true
req.Include.NumExecutions = 128
-
- So(req, WalkShouldReturn(c), &dm.GraphData{
+ tok := string(fake.MkToken(dm.NewExecutionID(w, 1, 1)))
+ aExpect := dm.NewAttemptExecuting(1)
+ aExpect.Executions = map[uint32]*dm.Execution{1: dm.NewExecutionScheduling()}
+ aExpect.Executions[1].Data.DistributorInfo = &dm.Execution_Data_DistributorInfo{
+ ConfigName: "fakeDistributor",
+ ConfigVersion: "testing",
+ Token: tok,
+ }
+ So(req, fake.WalkShouldReturn(c, s), &dm.GraphData{
Quests: map[string]*dm.Quest{
w: {
Data: &dm.Quest_Data{
Desc: wDesc,
},
- Attempts: map[uint32]*dm.Attempt{
- 1: dm.NewAttemptNeedsExecution(time.Time{}),
- },
+ Attempts: map[uint32]*dm.Attempt{1: aExpect},
},
},
})
})
Convey("finished", func() {
- _, err := s.FinishAttempt(c, &dm.FinishAttemptReq{
- Auth: activate(c, execute(c, aid)),
- JsonResult: `{"data": ["very", "yes"]}`,
- Expiration: google_pb.NewTimestamp(clock.Now(c).Add(time.Hour * 24 * 4)),
+ wEx := dm.NewExecutionID(w, 1, 1)
+ dist.RunTask(c, wEx, func(tsk *fake.Task) error {
+ tsk.MustActivate(c, s).Finish(
+ `{"data": ["very", "yes"]}`, clock.Now(c).Add(time.Hour*24*4))
+ tsk.State = "distributorState"
+ return nil
})
- So(err, ShouldBeNil)
-
- ex := &model.Execution{ID: 1, Attempt: ds.MakeKey("Attempt", aid.DMEncoded())}
- So(ds.Get(ex), ShouldBeNil)
- ex.State = dm.Execution_FINISHED
- So(ds.Put(ex), ShouldBeNil)
+ ttest.Drain(c)
req.Include.AttemptData = true
req.Include.AttemptResult = true
req.Include.NumExecutions = 128
+ req.Include.ExecutionInfoUrl = true
data := `{"data":["very","yes"]}`
- aExpect := dm.NewAttemptFinished(time.Time{}, uint32(len(data)), data)
+ aExpect := dm.NewAttemptFinished(time.Time{}, uint32(len(data)), data, "distributorState")
aExpect.Data.NumExecutions = 1
- aExpect.Executions = map[uint32]*dm.Execution{1: {
- Data: &dm.Execution_Data{
- State: dm.Execution_FINISHED,
- },
- }}
- So(req, WalkShouldReturn(c), &dm.GraphData{
+ aExpect.Executions = map[uint32]*dm.Execution{
+ 1: dm.NewExecutionFinished("distributorState"),
+ }
+ tok := string(fake.MkToken(dm.NewExecutionID(w, 1, 1)))
+ aExpect.Executions[1].Data.DistributorInfo = &dm.Execution_Data_DistributorInfo{
+ ConfigName: "fakeDistributor",
+ ConfigVersion: "testing",
+ Token: tok,
+ Url: dist.InfoURL(distributor.Token(tok)),
+ }
+
+ So(req, fake.WalkShouldReturn(c, s), &dm.GraphData{
Quests: map[string]*dm.Quest{
w: {
Attempts: map[uint32]*dm.Attempt{1: aExpect},
@@ -151,25 +155,22 @@ func TestWalkGraph(t *testing.T) {
})
Convey("limited attempt results", func() {
- _, err := s.FinishAttempt(c, &dm.FinishAttemptReq{
- Auth: activate(c, execute(c, aid)),
- JsonResult: `{"data": ["very", "yes"]}`,
- Expiration: google_pb.NewTimestamp(clock.Now(c).Add(time.Hour * 24 * 4)),
+ wEx := dm.NewExecutionID(w, 1, 1)
+ dist.RunTask(c, wEx, func(tsk *fake.Task) error {
+ tsk.MustActivate(c, s).Finish(
+ `{"data": ["very", "yes"]}`, clock.Now(c).Add(time.Hour*24*4))
+ tsk.State = "distributorState"
+ return nil
})
- So(err, ShouldBeNil)
-
- ex := &model.Execution{ID: 1, Attempt: ds.MakeKey("Attempt", aid.DMEncoded())}
- So(ds.Get(ex), ShouldBeNil)
- ex.State = dm.Execution_FINISHED
- So(ds.Put(ex), ShouldBeNil)
+ ttest.Drain(c)
req.Include.AttemptResult = true
req.Limit.MaxDataSize = 10
data := `{"data":["very","yes"]}`
- aExpect := dm.NewAttemptFinished(time.Time{}, uint32(len(data)), "")
+ aExpect := dm.NewAttemptFinished(time.Time{}, uint32(len(data)), "", "")
aExpect.Data.NumExecutions = 1
aExpect.Partial = &dm.Attempt_Partial{Result: dm.Attempt_Partial_DATA_SIZE_LIMIT}
- So(req, WalkShouldReturn(c), &dm.GraphData{
+ So(req, fake.WalkShouldReturn(c, s), &dm.GraphData{
Quests: map[string]*dm.Quest{
w: {
Attempts: map[uint32]*dm.Attempt{1: aExpect},
@@ -179,17 +180,22 @@ func TestWalkGraph(t *testing.T) {
})
Convey("attemptRange", func() {
- x := ensureQuest(c, "x", 1)
+ x := s.ensureQuest(c, "x", 1)
ttest.Drain(c)
- depOn(c, activate(c, execute(c, dm.NewAttemptID(w, 1))),
- dm.NewAttemptID(x, 1), dm.NewAttemptID(x, 2), dm.NewAttemptID(x, 3),
- dm.NewAttemptID(x, 4))
+
+ wEx := dm.NewExecutionID(w, 1, 1)
+ dist.RunTask(c, wEx, func(tsk *fake.Task) error {
+ tsk.MustActivate(c, s).DepOn(
+ dm.NewAttemptID(x, 1), dm.NewAttemptID(x, 2), dm.NewAttemptID(x, 3),
+ dm.NewAttemptID(x, 4))
+ return nil
+ })
ttest.Drain(c)
req.Limit.MaxDepth = 1
Convey("normal", func() {
req.Query = dm.AttemptRangeQuery(x, 2, 4)
- So(req, WalkShouldReturn(c), &dm.GraphData{
+ So(req, fake.WalkShouldReturn(c, s), &dm.GraphData{
Quests: map[string]*dm.Quest{
x: {Attempts: map[uint32]*dm.Attempt{2: {}, 3: {}}},
},
@@ -198,7 +204,7 @@ func TestWalkGraph(t *testing.T) {
Convey("oob range", func() {
req.Query = dm.AttemptRangeQuery(x, 2, 6)
- So(req, WalkShouldReturn(c), &dm.GraphData{
+ So(req, fake.WalkShouldReturn(c, s), &dm.GraphData{
Quests: map[string]*dm.Quest{
x: {Attempts: map[uint32]*dm.Attempt{
2: {}, 3: {}, 4: {}, 5: {DNE: true}}},
@@ -208,104 +214,131 @@ func TestWalkGraph(t *testing.T) {
})
Convey("filtered attempt results", func() {
- x := ensureQuest(c, "x", 2)
+ x := s.ensureQuest(c, "x", 2)
ttest.Drain(c)
- depOn(c, activate(c, execute(c, dm.NewAttemptID(w, 1))), dm.NewAttemptID(x, 1))
+
+ dist.RunTask(c, dm.NewExecutionID(w, 1, 1), func(tsk *fake.Task) error {
+ tsk.MustActivate(c, s).DepOn(dm.NewAttemptID(x, 1))
+ tsk.State = "originalState"
+ return nil
+ })
ttest.Drain(c)
- exp := google_pb.NewTimestamp(datastore.RoundTime(clock.Now(c).Add(time.Hour * 24 * 4)))
+ exp := datastore.RoundTime(clock.Now(c).Add(time.Hour * 24 * 4))
x1data := `{"data":["I can see this"]}`
- _, err := s.FinishAttempt(c, &dm.FinishAttemptReq{
- Auth: activate(c, execute(c, dm.NewAttemptID(x, 1))),
- JsonResult: x1data,
- Expiration: exp,
+ dist.RunTask(c, dm.NewExecutionID(x, 1, 1), func(tsk *fake.Task) error {
+ tsk.MustActivate(c, s).Finish(x1data, exp)
+ tsk.State = "atmpt1"
+ return nil
})
- So(err, ShouldBeNil)
x2data := `{"data":["nope"]}`
- _, err = s.FinishAttempt(c, &dm.FinishAttemptReq{
- Auth: activate(c, execute(c, dm.NewAttemptID(x, 2))),
- JsonResult: x2data,
- Expiration: exp,
+ dist.RunTask(c, dm.NewExecutionID(x, 2, 1), func(tsk *fake.Task) error {
+ tsk.MustActivate(c, s).Finish(x2data, exp)
+ tsk.State = "atmpt2"
+ return nil
})
- So(err, ShouldBeNil)
+
+ // This Drain does:
+ // RecordCompletion -> AckFwdDep -> ScheduleExecution
+ // which attempts to load the configuration from the context, and
+ // panics if it's missing.
ttest.Drain(c)
- req.Auth = activate(c, execute(c, dm.NewAttemptID(w, 1)))
- req.Limit.MaxDepth = 2
- req.Include.AttemptResult = true
- req.Query = dm.AttemptListQueryL(map[string][]uint32{x: nil})
+ wEID := dm.NewExecutionID(w, 1, 2)
+ wEx := model.ExecutionFromID(c, wEID)
+ So(ds.Get(wEx), ShouldBeNil)
- x1Expect := dm.NewAttemptFinished(time.Time{}, uint32(len(x1data)), x1data)
- x1Expect.Data.NumExecutions = 1
+ dist.RunTask(c, wEID, func(tsk *fake.Task) error {
+ So(tsk.State, ShouldEqual, "originalState")
- x2Expect := dm.NewAttemptFinished(time.Time{}, uint32(len(x2data)), "")
- x2Expect.Partial = &dm.Attempt_Partial{Result: dm.Attempt_Partial_NOT_AUTHORIZED}
- x2Expect.Data.NumExecutions = 1
+ act := tsk.MustActivate(c, s)
+ req.Limit.MaxDepth = 2
+ req.Include.AttemptResult = true
+ req.Query = dm.AttemptListQueryL(map[string][]uint32{x: nil})
- So(req, WalkShouldReturn(c), &dm.GraphData{
- Quests: map[string]*dm.Quest{
- x: {Attempts: map[uint32]*dm.Attempt{
- 1: x1Expect,
- 2: x2Expect,
- }},
- }})
+ x1Expect := dm.NewAttemptFinished(time.Time{}, uint32(len(x1data)), x1data, "atmpt1")
+ x1Expect.Data.NumExecutions = 1
+
+ x2Expect := dm.NewAttemptFinished(time.Time{}, uint32(len(x2data)), "", "")
+ x2Expect.Partial = &dm.Attempt_Partial{Result: dm.Attempt_Partial_NOT_AUTHORIZED}
+ x2Expect.Data.NumExecutions = 1
+
+ So(req, act.WalkShouldReturn, &dm.GraphData{
+ Quests: map[string]*dm.Quest{
+ x: {Attempts: map[uint32]*dm.Attempt{
+ 1: x1Expect,
+ 2: x2Expect,
+ }},
+ },
+ })
+ return nil
+ })
})
Convey("own attempt results", func() {
- x := ensureQuest(c, "x", 2)
+ x := s.ensureQuest(c, "x", 2)
ttest.Drain(c)
- depOn(c, activate(c, execute(c, dm.NewAttemptID(w, 1))), dm.NewAttemptID(x, 1))
+ dist.RunTask(c, dm.NewExecutionID(w, 1, 1), func(tsk *fake.Task) error {
+ tsk.MustActivate(c, s).DepOn(dm.NewAttemptID(x, 1))
+ return nil
+ })
ttest.Drain(c)
- exp := google_pb.NewTimestamp(datastore.RoundTime(clock.Now(c).Add(time.Hour * 24 * 4)))
+ exp := datastore.RoundTime(clock.Now(c).Add(time.Hour * 24 * 4))
x1data := `{"data":["I can see this"]}`
- _, err := s.FinishAttempt(c, &dm.FinishAttemptReq{
- Auth: activate(c, execute(c, dm.NewAttemptID(x, 1))),
- JsonResult: x1data,
- Expiration: exp,
+ dist.RunTask(c, dm.NewExecutionID(x, 1, 1), func(tsk *fake.Task) error {
+ tsk.MustActivate(c, s).Finish(x1data, exp)
+ tsk.State = "state"
+ return nil
})
- So(err, ShouldBeNil)
ttest.Drain(c)
- req.Auth = activate(c, execute(c, dm.NewAttemptID(w, 1)))
- req.Limit.MaxDepth = 2
- req.Include.AttemptResult = true
- req.Query = dm.AttemptListQueryL(map[string][]uint32{w: {1}})
+ dist.RunTask(c, dm.NewExecutionID(w, 1, 2), func(tsk *fake.Task) error {
+ act := tsk.MustActivate(c, s)
+ req.Limit.MaxDepth = 2
+ req.Include.AttemptResult = true
+ req.Query = dm.AttemptListQueryL(map[string][]uint32{w: {1}})
- x1Expect := dm.NewAttemptFinished(time.Time{}, uint32(len(x1data)), x1data)
- x1Expect.Data.NumExecutions = 1
+ x1Expect := dm.NewAttemptFinished(time.Time{}, uint32(len(x1data)), x1data, "state")
+ x1Expect.Data.NumExecutions = 1
- w1Exepct := dm.NewAttemptExecuting(2)
- w1Exepct.Data.NumExecutions = 2
+ w1Exepct := dm.NewAttemptExecuting(2)
+ w1Exepct.Data.NumExecutions = 2
- // This filter ensures that WalkShouldReturn is using the optimized
- // path for deps traversal when starting from an authed attempt.
- c = datastore.AddRawFilters(c, func(c context.Context, ri datastore.RawInterface) datastore.RawInterface {
- return breakFwdDepLoads{ri}
- })
+ // This filter ensures that WalkShouldReturn is using the optimized
+ // path for deps traversal when starting from an authed attempt.
+ c = datastore.AddRawFilters(c, func(c context.Context, ri datastore.RawInterface) datastore.RawInterface {
+ return breakFwdDepLoads{ri}
+ })
- So(req, WalkShouldReturn(c), &dm.GraphData{
- Quests: map[string]*dm.Quest{
- w: {Attempts: map[uint32]*dm.Attempt{1: w1Exepct}},
- x: {Attempts: map[uint32]*dm.Attempt{1: x1Expect}},
- }})
+ So(req, act.WalkShouldReturn, &dm.GraphData{
+ Quests: map[string]*dm.Quest{
+ w: {Attempts: map[uint32]*dm.Attempt{1: w1Exepct}},
+ x: {Attempts: map[uint32]*dm.Attempt{1: x1Expect}},
+ },
+ })
+ return nil
+ })
})
Convey("deps (no dest attempts)", func() {
req.Limit.MaxDepth = 3
- w1auth := activate(c, execute(c, dm.NewAttemptID(w, 1)))
- x := ensureQuest(c, "x", 1)
+
+ x := s.ensureQuest(c, "x", 1)
ttest.Drain(c)
- depOn(c, w1auth, dm.NewAttemptID(x, 1), dm.NewAttemptID(x, 2))
- Convey("before tumble", func() {
- Convey("deps", func() {
+ dist.RunTask(c, dm.NewExecutionID(w, 1, 1), func(tsk *fake.Task) error {
+ tsk.MustActivate(c, s).DepOn(dm.NewAttemptID(x, 1), dm.NewAttemptID(x, 2))
+
+ Convey("before tumble", func() {
req.Include.FwdDeps = true
// didn't run tumble, so that x|1 and x|2 don't get created.
- So(req, WalkShouldReturn(c), &dm.GraphData{
+ // don't use act.WalkShouldReturn; we want to observe the graph
+ // state from
+ So(req, fake.WalkShouldReturn(c, s), &dm.GraphData{
Quests: map[string]*dm.Quest{
w: {Attempts: map[uint32]*dm.Attempt{1: {
FwdDeps: dm.NewAttemptList(map[string][]uint32{
@@ -319,14 +352,16 @@ func TestWalkGraph(t *testing.T) {
},
})
})
+ return nil
})
Convey("after tumble", func() {
ttest.Drain(c)
+
Convey("deps (with dest attempts)", func() {
req.Include.FwdDeps = true
req.Include.BackDeps = true
- So(req, WalkShouldReturn(c), &dm.GraphData{
+ So(req, fake.WalkShouldReturn(c, s), &dm.GraphData{
Quests: map[string]*dm.Quest{
w: {Attempts: map[uint32]*dm.Attempt{1: {
FwdDeps: dm.NewAttemptList(map[string][]uint32{x: {2, 1}}),
@@ -344,43 +379,47 @@ func TestWalkGraph(t *testing.T) {
})
Convey("diamond", func() {
- z := ensureQuest(c, "z", 1)
- ttest.Drain(c)
- depOn(c, activate(c, execute(c, dm.NewAttemptID(x, 1))), dm.NewAttemptID(z, 1))
- depOn(c, activate(c, execute(c, dm.NewAttemptID(x, 2))), dm.NewAttemptID(z, 1))
+ z := s.ensureQuest(c, "z", 1)
ttest.Drain(c)
- So(req, WalkShouldReturn(c), &dm.GraphData{
- Quests: map[string]*dm.Quest{
- w: {Attempts: map[uint32]*dm.Attempt{1: {}}},
- x: {Attempts: map[uint32]*dm.Attempt{1: {}, 2: {}}},
- z: {Attempts: map[uint32]*dm.Attempt{1: {}}},
- },
+ dist.RunTask(c, dm.NewExecutionID(x, 1, 1), func(tsk *fake.Task) error {
+ tsk.MustActivate(c, s).DepOn(dm.NewAttemptID(z, 1))
+ return nil
+ })
+ dist.RunTask(c, dm.NewExecutionID(x, 2, 1), func(tsk *fake.Task) error {
+ tsk.MustActivate(c, s).DepOn(dm.NewAttemptID(z, 1))
+ return nil
})
- })
-
- Convey("diamond (dfs)", func() {
- z := ensureQuest(c, "z", 1)
- ttest.Drain(c)
- depOn(c, activate(c, execute(c, dm.NewAttemptID(x, 1))), dm.NewAttemptID(z, 1))
- depOn(c, activate(c, execute(c, dm.NewAttemptID(x, 2))), dm.NewAttemptID(z, 1))
ttest.Drain(c)
- req.Mode.Dfs = true
- So(req, WalkShouldReturn(c), &dm.GraphData{
- Quests: map[string]*dm.Quest{
- w: {Attempts: map[uint32]*dm.Attempt{1: {}}},
- x: {Attempts: map[uint32]*dm.Attempt{1: {}, 2: {}}},
- z: {Attempts: map[uint32]*dm.Attempt{1: {}}},
- },
+ Convey("walk", func() {
+ So(req, fake.WalkShouldReturn(c, s), &dm.GraphData{
+ Quests: map[string]*dm.Quest{
+ w: {Attempts: map[uint32]*dm.Attempt{1: {}}},
+ x: {Attempts: map[uint32]*dm.Attempt{1: {}, 2: {}}},
+ z: {Attempts: map[uint32]*dm.Attempt{1: {}}},
+ },
+ })
+ })
+
+ Convey("walk (dfs)", func() {
+ req.Mode.Dfs = true
+ So(req, fake.WalkShouldReturn(c, s), &dm.GraphData{
+ Quests: map[string]*dm.Quest{
+ w: {Attempts: map[uint32]*dm.Attempt{1: {}}},
+ x: {Attempts: map[uint32]*dm.Attempt{1: {}, 2: {}}},
+ z: {Attempts: map[uint32]*dm.Attempt{1: {}}},
+ },
+ })
})
+
})
Convey("attemptlist", func() {
req.Limit.MaxDepth = 1
req.Include.ObjectIds = true
req.Query = dm.AttemptListQueryL(map[string][]uint32{x: nil})
- So(req, WalkShouldReturn(c), &dm.GraphData{
+ So(req, fake.WalkShouldReturn(c, s), &dm.GraphData{
Quests: map[string]*dm.Quest{
x: {
Id: dm.NewQuestID(x),
@@ -402,7 +441,7 @@ func TestWalkGraph(t *testing.T) {
tc.SetTimerCallback(func(d time.Duration, t clock.Timer) {
tc.Add(d + time.Second)
})
- ret, err := newDecoratedDeps().WalkGraph(c, req)
+ ret, err := s.WalkGraph(c, req)
So(err, ShouldBeNil)
So(ret.HadMore, ShouldBeTrue)
})
« appengine/cmd/dm/deps/walk_graph.go ('K') | « appengine/cmd/dm/deps/walk_graph.go ('k') | appengine/cmd/dm/distributor/config.go » ('j') | appengine/cmd/dm/distributor/distributor.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698