common/api/dm/service/v1/graph_data_clone.go - Issue 1537883002: Initial distributor implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: common/api/dm/service/v1/graph_data_clone.go

Issue 1537883002: Initial distributor implementation (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Fix comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 package dm

	6

	7 // Clone returns a deep copy of this Quest_Desc.
	dnj (Google) 2016/06/16 16:57:22 nit: mention that this only works on Normalized de nit: mention that this only works on Normalized descriptors? b/c if Meta or Retry are nil, this will panic. Or is that implicit? iannucci 2016/06/18 01:35:41 Switched to proto.Clone anyway :) Show quoted text On 2016/06/16 16:57:22, dnj (Google) wrote: > nit: mention that this only works on Normalized descriptors? b/c if Meta or > Retry are nil, this will panic. Or is that implicit? Switched to proto.Clone anyway :)
	8 func (d Quest_Desc) Clone() Quest_Desc {

	9 ret := *d

	10 meta := *ret.Meta

	11 retry := *meta.Retry

	12

	13 meta.Retry = &retry

	14 ret.Meta = &meta

	15 return &ret

	16 }

OLD	NEW