Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Issue 15373002: Try to reduce the flakiness of 4 :hover tests. (Closed)

Created:
7 years, 7 months ago by Julien - ping for review
Modified:
7 years, 7 months ago
Reviewers:
eseidel
CC:
blink-reviews, shans, dstockwell, Steve Block, eae+blinkwatch, darktears
Visibility:
Public.

Description

Try to reduce the flakiness of 4 :hover tests. Based on what is currently done throughout the LayoutTests/, there are 2 ways to reduce the flakiness of a :hover test: * Force layout before and after moving the mouse (especially since some tests claim that we don't track the mouse before first layout). * Force a click after moving the mouse. This change implements the first option as the second one didn't work for these tests (I remember that it helped in webkit.org/b/81460 though). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150693

Patch Set 1 #

Patch Set 2 : Switched to the first option #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transform.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transition.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-69296.html View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Julien - ping for review
3 try runs without any of the tests failing, it seems like it did the ...
7 years, 7 months ago (2013-05-20 19:53:40 UTC) #1
eseidel
lgtm OK.
7 years, 7 months ago (2013-05-20 19:54:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/15373002/3001
7 years, 7 months ago (2013-05-20 19:54:37 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-20 21:09:16 UTC) #4
Message was sent while issue was closed.
Change committed as 150693

Powered by Google App Engine
This is Rietveld 408576698