Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 15358005: Don't create new maps in CurrentMapForDeprecated. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest
Modified:
7 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Don't create new maps in CurrentMapForDeprecated. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14728

Patch Set 1 #

Patch Set 2 : Ignore deprecated feedback maps that aren't updateable #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -36 lines) Patch
M src/ast.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects.cc View 1 2 3 chunks +29 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/type-info.cc View 1 2 8 chunks +27 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 7 months ago (2013-05-21 08:46:02 UTC) #1
Yang
LGTM.
7 years, 7 months ago (2013-05-21 11:01:54 UTC) #2
Toon Verwaest
7 years, 7 months ago (2013-05-21 11:20:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r14728 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698