http 'new' opens 2 tabs when there are no windows on cros.

http 'new' opens 2 tabs when there are no windows on cros.

BUG=241925
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202028

[Tim Song, 2013-05-20 22:48:41]

https://codereview.chromium.org/15356002/diff/3001/chrome/browser/devtools/br...
File chrome/browser/devtools/browser_list_tabcontents_provider.cc (right):

https://codereview.chromium.org/15356002/diff/3001/chrome/browser/devtools/br...
chrome/browser/devtools/browser_list_tabcontents_provider.cc:37: :
profile_(profile->GetOriginalProfile()),
If the profile being passed in here is an incognito profile, and this is not
expected, shouldn't there be a problem in whatever is creating this object?

https://codereview.chromium.org/15356002/diff/3001/chrome/browser/devtools/br...
chrome/browser/devtools/browser_list_tabcontents_provider.cc:100:
GetRenderViewHost();
This is good, as we don't want two tabs being open if there is no browser.
However, I'm curious when this happens with telemetry. There is a check in
tools/telemetry/telemetry/core/chrome/tab_list_backend.py that creates a new tab
should the last tab ever be closed.

[achuithb, 2013-05-20 23:10:00]

https://codereview.chromium.org/15356002/diff/3001/chrome/browser/devtools/br...
File chrome/browser/devtools/browser_list_tabcontents_provider.cc (right):

https://codereview.chromium.org/15356002/diff/3001/chrome/browser/devtools/br...
chrome/browser/devtools/browser_list_tabcontents_provider.cc:37: :
profile_(profile->GetOriginalProfile()),
On 2013/05/20 22:48:41, tengs wrote:
> If the profile being passed in here is an incognito profile, and this is not
> expected, shouldn't there be a problem in whatever is creating this object?

Yup, that's here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...

I haven't investigated this

https://codereview.chromium.org/15356002/diff/3001/chrome/browser/devtools/br...
chrome/browser/devtools/browser_list_tabcontents_provider.cc:100:
GetRenderViewHost();
On 2013/05/20 22:48:41, tengs wrote:
> This is good, as we don't want two tabs being open if there is no browser.
> However, I'm curious when this happens with telemetry. There is a check in
> tools/telemetry/telemetry/core/chrome/tab_list_backend.py that creates a new
tab
> should the last tab ever be closed.

That code only kicks in when a tab is closed. This is startup code and no
windows/tabs are present when we call this function.

[achuithb, 2013-05-23 23:33:37]

PTAL, Tim, and Yury.

[Tim Song, 2013-05-24 00:17:47]

On 2013/05/23 23:33:37, achuith.bhandarkar wrote:
> PTAL, Tim, and Yury.

LGTM

[yurys, 2013-05-24 03:59:52]

lgtm

[achuithb, 2013-05-24 04:00:46]

On 2013/05/24 03:59:52, Yury Semikhatsky wrote:
> lgtm

Thank you!

[commit-bot: I haz the power, 2013-05-24 04:01:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/15356002/12001

[commit-bot: I haz the power, 2013-05-24 09:21:22]

Change committed as 202028