Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1392)

Unified Diff: src/trusted/validator_mips/validator.h

Issue 1535443005: [MIPS] Make validator allow only two load patterns via $t8 (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client@master
Patch Set: Minor update. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator_mips/validation-report.py ('k') | src/trusted/validator_mips/validator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_mips/validator.h
diff --git a/src/trusted/validator_mips/validator.h b/src/trusted/validator_mips/validator.h
index 85f0236a159c412d0e915b374950e268a48dded1..377a2233f63ff51849a02cf29f824f8084b376f1 100644
--- a/src/trusted/validator_mips/validator.h
+++ b/src/trusted/validator_mips/validator.h
@@ -274,6 +274,14 @@ class DecodedInstruction {
return decoder_->IsLoadStore();
}
+ bool IsLoadWord() const {
+ return decoder_->IsLoadWord();
+ }
+
+ uint32_t GetImm() const {
+ return decoder_->GetImm(inst_);
+ }
+
bool IsDirectJump() const {
return decoder_->IsDirectJump();
}
@@ -385,6 +393,9 @@ const char * const kProblemBranchSplitsPattern = "kProblemBranchSplitsPattern";
const char * const kProblemBranchInvalidDest = "kProblemBranchInvalidDest";
// A load/store uses an unsafe (non-masked) base address.
const char * const kProblemUnsafeLoadStore = "kProblemUnsafeLoadStore";
+// A thread pointer load/store is unsafe.
+const char * const kProblemUnsafeLoadStoreThreadPointer =
+ "kProblemUnsafeLoadStoreThreadPointer";
// An instruction updates a data-address register (e.g. SP) without masking.
const char * const kProblemUnsafeDataWrite = "kProblemUnsafeDataWrite";
// An instruction updates a read-only register (e.g. t6, t7, t8).
« no previous file with comments | « src/trusted/validator_mips/validation-report.py ('k') | src/trusted/validator_mips/validator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698