third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h - Issue 1534813004: Run smooth scroll animations on the compositor when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

Issue 1534813004: Run smooth scroll animations on the compositor when possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

index f10acb31d9b79778dea83d4b918041c2feaf3d6d..440aa7e445f6dfc848e99b6ad234cefda4eba95f 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

@@ -22,9 +22,9 @@ public:

virtual ~ScrollAnimatorCompositorCoordinator();

bool hasAnimationThatRequiresService() const;

- void cancelAnimation();

virtual void resetAnimationState();

+ virtual void cancelAnimation();

virtual ScrollableArea* scrollableArea() const = 0;

virtual void tickAnimation(double monotonicTime) = 0;

@@ -39,6 +39,7 @@ protected:

bool addAnimation(PassOwnPtr<WebCompositorAnimation>);

void removeAnimation();

+ void abortAnimation();

void compositorAnimationFinished(int groupId);

void reattachCompositorPlayerIfNeeded(WebCompositorAnimationTimeline*);

@@ -62,6 +63,9 @@ protected:

// Running an animation on the compositor.

RunningOnCompositor,

+ // Running an animation on the compositor but needs update.

+ RunningOnCompositorButNeedsUpdate,

// Running an animation on the main thread.

RunningOnMainThread,