third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp - Issue 1534813004: Run smooth scroll animations on the compositor when possible

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp

Issue 1534813004: Run smooth scroll animations on the compositor when possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h ('k') | third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2010, Google Inc. All rights reserved.	2 * Copyright (c) 2010, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 87 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
98 float ScrollAnimatorBase::clampScrollPosition(ScrollbarOrientation orientation, float pos) const	98 float ScrollAnimatorBase::clampScrollPosition(ScrollbarOrientation orientation, float pos) const

99 {	99 {

100 float maxScrollPos = m_scrollableArea->maximumScrollPosition(orientation);	100 float maxScrollPos = m_scrollableArea->maximumScrollPosition(orientation);

101 float minScrollPos = m_scrollableArea->minimumScrollPosition(orientation);	101 float minScrollPos = m_scrollableArea->minimumScrollPosition(orientation);

102 return std::max(std::min(pos, maxScrollPos), minScrollPos);	102 return std::max(std::min(pos, maxScrollPos), minScrollPos);

103 }	103 }

104	104

105 DEFINE_TRACE(ScrollAnimatorBase)	105 DEFINE_TRACE(ScrollAnimatorBase)

106 {	106 {

107 visitor->trace(m_scrollableArea);	107 visitor->trace(m_scrollableArea);

	108 ScrollAnimatorCompositorCoordinator::trace(visitor);

108 }	109 }

109	110

110 } // namespace blink	111 } // namespace blink

OLD	NEW