Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1534813004: Run smooth scroll animations on the compositor when possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 // Propagate the marginwidth/height and scrolling modes to the view. 258 // Propagate the marginwidth/height and scrolling modes to the view.
259 if (m_frame->owner() && m_frame->owner()->scrollingMode() == ScrollbarAlways Off) 259 if (m_frame->owner() && m_frame->owner()->scrollingMode() == ScrollbarAlways Off)
260 setCanHaveScrollbars(false); 260 setCanHaveScrollbars(false);
261 } 261 }
262 262
263 void FrameView::dispose() 263 void FrameView::dispose()
264 { 264 {
265 RELEASE_ASSERT(!isInPerformLayout()); 265 RELEASE_ASSERT(!isInPerformLayout());
266 266
267 if (ScrollAnimatorBase* scrollAnimator = existingScrollAnimator()) 267 if (ScrollAnimatorBase* scrollAnimator = existingScrollAnimator())
268 scrollAnimator->cancelAnimations(); 268 scrollAnimator->cancelAnimation();
269 cancelProgrammaticScrollAnimation(); 269 cancelProgrammaticScrollAnimation();
270 270
271 detachScrollbars(); 271 detachScrollbars();
272 272
273 // When the view is no longer associated with a frame, it needs to be remove d from the ax object cache 273 // When the view is no longer associated with a frame, it needs to be remove d from the ax object cache
274 // right now, otherwise it won't be able to reach the topDocument()'s axObje ct cache later. 274 // right now, otherwise it won't be able to reach the topDocument()'s axObje ct cache later.
275 removeFromAXObjectCache(); 275 removeFromAXObjectCache();
276 276
277 if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator( )) 277 if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator( ))
278 scrollingCoordinator->willDestroyScrollableArea(this); 278 scrollingCoordinator->willDestroyScrollableArea(this);
(...skipping 3727 matching lines...) Expand 10 before | Expand all | Expand 10 after
4006 return m_hiddenForThrottling && m_crossOriginForThrottling; 4006 return m_hiddenForThrottling && m_crossOriginForThrottling;
4007 } 4007 }
4008 4008
4009 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const 4009 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const
4010 { 4010 {
4011 ASSERT(layoutView()); 4011 ASSERT(layoutView());
4012 return *layoutView(); 4012 return *layoutView();
4013 } 4013 }
4014 4014
4015 } // namespace blink 4015 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698