Opt out of download feedback from settings

chrome/browser/ui/webui/options/browser_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/browser_options_handler.h"
 
 #include <string>
 #include <vector>
 
 #include "apps/shell_window.h"
@@ skipping 27 matching lines @@
 #include "chrome/browser/profile_resetter/automatic_profile_resetter.h"
 #include "chrome/browser/profile_resetter/automatic_profile_resetter_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_info_util.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/profiles/profile_metrics.h"
 #include "chrome/browser/profiles/profile_shortcut_manager.h"
 #include "chrome/browser/profiles/profile_window.h"
 #include "chrome/browser/profiles/profiles_state.h"
+#include "chrome/browser/safe_browsing/download_feedback_service.h"
 #include "chrome/browser/search/hotword_service.h"
 #include "chrome/browser/search/hotword_service_factory.h"
 #include "chrome/browser/search/search.h"
 #include "chrome/browser/search_engines/template_url.h"
 #include "chrome/browser/search_engines/template_url_service.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/signin/signin_manager.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
@@ skipping 68 matching lines @@
 #if defined(ENABLE_MDNS)
 #include "chrome/browser/local_discovery/privet_notifications.h"
 #endif
 
 using base::UserMetricsAction;
 using content::BrowserContext;
 using content::BrowserThread;
 using content::DownloadManager;
 using content::OpenURLParams;
 using content::Referrer;
+using safe_browsing::DownloadFeedbackService;
 
 namespace options {
 
 namespace {
 
 bool ShouldShowMultiProfilesUserList(chrome::HostDesktopType desktop_type) {
 #if defined(OS_CHROMEOS)
   // On Chrome OS we use different UI for multi-profiles.
   return false;
 #else
@@ skipping 146 matching lines @@
     { "proxiesLabelExtension", IDS_OPTIONS_EXTENSION_PROXIES_LABEL },
     { "proxiesLabelSystem", IDS_OPTIONS_SYSTEM_PROXIES_LABEL,
       IDS_PRODUCT_NAME },
     { "resetProfileSettings", IDS_RESET_PROFILE_SETTINGS_BUTTON },
     { "resetProfileSettingsDescription",
       IDS_RESET_PROFILE_SETTINGS_DESCRIPTION },
     { "resetProfileSettingsSectionTitle",
       IDS_RESET_PROFILE_SETTINGS_SECTION_TITLE },
     { "safeBrowsingEnableProtection",
       IDS_OPTIONS_SAFEBROWSING_ENABLEPROTECTION },
+    { "safeBrowsingEnableDownloadFeedback",
+      IDS_OPTIONS_SAFEBROWSING_ENABLEDOWNLOADFEEDBACK },
     { "sectionTitleAppearance", IDS_APPEARANCE_GROUP_NAME },
     { "sectionTitleDefaultBrowser", IDS_OPTIONS_DEFAULTBROWSER_GROUP_NAME },
     { "sectionTitleUsers", IDS_PROFILES_OPTIONS_GROUP_NAME },
     { "sectionTitleSearch", IDS_OPTIONS_DEFAULTSEARCH_GROUP_NAME },
     { "sectionTitleStartup", IDS_OPTIONS_STARTUP_GROUP_NAME },
     { "sectionTitleSync", IDS_SYNC_OPTIONS_GROUP_NAME },
     { "spellingConfirmMessage", IDS_CONTENT_CONTEXT_SPELLING_BUBBLE_TEXT },
     { "spellingConfirmEnable", IDS_CONTENT_CONTEXT_SPELLING_BUBBLE_ENABLE },
     { "spellingConfirmDisable", IDS_CONTENT_CONTEXT_SPELLING_BUBBLE_DISABLE },
     { "spellingPref", IDS_OPTIONS_SPELLING_PREF },
@@ skipping 260 matching lines @@
                      !local_discovery::PrivetNotificationService::IsEnabled());
 #endif
 
   values->SetBoolean("cloudPrintShowMDnsOptions",
                      cloud_print_mdns_ui_enabled_);
 
   values->SetString("cloudPrintLearnMoreURL", chrome::kCloudPrintLearnMoreURL);
 
   values->SetString("languagesLearnMoreURL",
                     chrome::kLanguageSettingsLearnMoreUrl);
+
+  PrefService* pref_service = Profile::FromWebUI(web_ui())->GetPrefs();
+  DownloadFeedbackService::DownloadReportingStatus reporting_pref =
+      static_cast<DownloadFeedbackService::DownloadReportingStatus>(
+          pref_service->GetInteger(
+              prefs::kSafeBrowsingDownloadReportingEnabled));
+  values->SetBoolean(
+      "sbDownloadFeedbackEnabled",
+      reporting_pref == DownloadFeedbackService::kDownloadReportingEnabled);
 }
 
 #if defined(ENABLE_FULL_PRINTING)
 void BrowserOptionsHandler::RegisterCloudPrintValues(
     base::DictionaryValue* values) {
   values->SetString("cloudPrintOptionLabel",
                     l10n_util::GetStringFUTF16(
                         IDS_CLOUD_PRINT_CHROMEOS_OPTION_LABEL,
                         l10n_util::GetStringUTF16(IDS_GOOGLE_CLOUD_PRINT)));
 
@@ skipping 115 matching lines @@
     web_ui()->RegisterMessageCallback(
         "showCloudPrintDevicesPage",
         base::Bind(&BrowserOptionsHandler::ShowCloudPrintDevicesPage,
                    base::Unretained(this)));
   }
 #endif
   web_ui()->RegisterMessageCallback(
       "requestHotwordAvailable",
       base::Bind(&BrowserOptionsHandler::HandleRequestHotwordAvailable,
                  base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
+      "downloadFeedbackStatusChanged",
+      base::Bind(&BrowserOptionsHandler::DownloadFeedbackStatusChanged,

[Dan Beam, 2014/02/12 22:53:04]

nit: HandleDownloadFeedbackStatusChanged

[felt, 2014/02/13 05:17:58]

Done.

+                 base::Unretained(this)));
 }
 
 void BrowserOptionsHandler::Uninitialize() {
   registrar_.RemoveAll();
 }
 
 void BrowserOptionsHandler::OnStateChanged() {
   UpdateSyncState();
 }
 
@@ skipping 798 matching lines @@
 void BrowserOptionsHandler::HandleRequestHotwordAvailable(
     const base::ListValue* args) {
   Profile* profile = Profile::FromWebUI(web_ui());
   std::string group = base::FieldTrialList::FindFullName("VoiceTrigger");
   if (group != "" && group != "Disabled" &&
       HotwordServiceFactory::IsServiceAvailable(profile)) {
     web_ui()->CallJavascriptFunction("BrowserOptions.showHotwordSection");
   }
 }
 
+void BrowserOptionsHandler::DownloadFeedbackStatusChanged(
+    const base::ListValue* args) {
+  bool enabled = false;
+  args->GetBoolean(0, &enabled);

[Dan Beam, 2014/02/12 22:53:04]

nit:

  bool success = args->GetBoolean(0, &enabled);
  DCHECK(success);

[felt, 2014/02/13 05:17:58]

Done.

+  PrefService* pref_service = Profile::FromWebUI(web_ui())->GetPrefs();
+  if (enabled) {
+    pref_service->SetInteger(
+        prefs::kSafeBrowsingDownloadReportingEnabled,
+        DownloadFeedbackService::kDownloadReportingEnabled);
+  } else {
+    pref_service->SetInteger(
+        prefs::kSafeBrowsingDownloadReportingEnabled,
+        DownloadFeedbackService::kDownloadReportingDisabled);
+  }

[Dan Beam, 2014/02/12 22:53:04]

nit:

  pref_service->SetInteger(
      prefs::kSafeBrowsingDownloadReportingEnabled,
      enabled ? DownloadFeedbackService::kDownloadReportingEnabled :
                DownloadFeedbackService::kDownloadReportingDisabled);

[felt, 2014/02/13 05:17:58]

Done.

+}
+
 #if defined(OS_CHROMEOS)
 void BrowserOptionsHandler::HandleOpenWallpaperManager(
     const base::ListValue* args) {
   wallpaper_manager_util::OpenWallpaperManager();
 }
 
 void BrowserOptionsHandler::VirtualKeyboardChangeCallback(
     const base::ListValue* args) {
   bool enabled = false;
   args->GetBoolean(0, &enabled);
@@ skipping 160 matching lines @@
 void BrowserOptionsHandler::SetupManagingSupervisedUsers() {
   bool has_users = !Profile::FromWebUI(web_ui())->
       GetPrefs()->GetDictionary(prefs::kManagedUsers)->empty();
   base::FundamentalValue has_users_value(has_users);
   web_ui()->CallJavascriptFunction(
       "BrowserOptions.updateManagesSupervisedUsers",
       has_users_value);
 }
 
 }  // namespace options