Issue 15333014: DevTools: InspectorFrontendHost::loadResourceSynchronously() builds ASCII-only results

Issue 15333014: DevTools: InspectorFrontendHost::loadResourceSynchronously() builds ASCII-only results (Closed)

Created:
7 years, 7 months ago by apavlov

Modified:
7 years, 7 months ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: InspectorFrontendHost::loadResourceSynchronously() builds ASCII-only results The result String is built from raw char* data.data() rather than using String::fromUTF8(). BUG=241893 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150773

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed comment #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
A	LayoutTests/inspector/load-resource-synchronously-utf8.html	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A	LayoutTests/inspector/load-resource-synchronously-utf8-expected.txt	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorFrontendHost.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://codereview.chromium.org/15333014/diff/1/Source/core/inspector/InspectorFrontendHost.cpp File Source/core/inspector/InspectorFrontendHost.cpp (right): https://codereview.chromium.org/15333014/diff/1/Source/core/inspector/InspectorFrontendHost.cpp#newcode270 Source/core/inspector/InspectorFrontendHost.cpp:270: // |data| contains raw UTF8 bytes of the ...

7 years, 7 months ago (2013-05-21 07:40:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/15333014/5001

7 years, 7 months ago (2013-05-21 07:48:51 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=6468

7 years, 7 months ago (2013-05-21 09:12:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/15333014/5001

7 years, 7 months ago (2013-05-21 11:10:06 UTC) #5

Message was sent while issue was closed.

Change committed as 150773

Expand Messages | Collapse Messages