Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15333013: Replace most of the occurrence of OperationRegistry with OperationRunner. (Closed)

Created:
7 years, 7 months ago by kinaba
Modified:
7 years, 7 months ago
Reviewers:
satorux1
CC:
chromium-reviews, nkostylev+watch_chromium.org, derat+watch_chromium.org, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Replace most of the occurrence of OperationRegistry with OperationRunner. This is a preparation for OperationRegistry removal. Each operation will interact directly with OperationRunner. BUG=164098 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -416 lines) Patch
M chrome/browser/chromeos/contacts/gdata_contacts_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/base_operations.h View 11 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/google_apis/base_operations.cc View 12 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/google_apis/base_operations_server_unittest.cc View 7 chunks +13 lines, -8 lines 0 comments Download
M chrome/browser/google_apis/base_operations_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/google_apis/drive_api_operations.h View 16 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/google_apis/drive_api_operations.cc View 19 chunks +32 lines, -32 lines 0 comments Download
M chrome/browser/google_apis/drive_api_operations_unittest.cc View 50 chunks +65 lines, -87 lines 0 comments Download
M chrome/browser/google_apis/drive_api_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/drive_api_service.cc View 24 chunks +23 lines, -27 lines 0 comments Download
M chrome/browser/google_apis/gdata_contacts_operations.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/gdata_contacts_operations.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations.h View 15 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations.cc View 19 chunks +30 lines, -30 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations_unittest.cc View 61 chunks +72 lines, -109 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.cc View 23 chunks +22 lines, -26 lines 0 comments Download
M chrome/browser/google_apis/test_util.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/google_apis/test_util.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
7 years, 7 months ago (2013-05-21 07:12:14 UTC) #1
satorux1
LGTM. Nice!
7 years, 7 months ago (2013-05-22 03:31:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/15333013/1
7 years, 7 months ago (2013-05-22 03:33:33 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-22 12:43:04 UTC) #4
Message was sent while issue was closed. 
Change committed as 201495

Powered by Google App Engine
This is Rietveld 408576698