Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: scripts/common/annotator.py

Issue 15329006: Fix seed_steps for generator annotation recipes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/annotated_run.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/common/annotator.py
diff --git a/scripts/common/annotator.py b/scripts/common/annotator.py
index bca5f3f1700cd66b18d203d72b7e6692fddedab4..e382581c1763dad0cd936e0f0763d8859ef1fef3 100755
--- a/scripts/common/annotator.py
+++ b/scripts/common/annotator.py
@@ -394,17 +394,15 @@ def _run_step(stream, build_failure,
return build_failure, ret
-def run_steps(steps, build_failure):
+def run_steps(steps, build_failure, seed_steps=None):
for step in steps:
error = _validate_step(step)
if error:
print 'Invalid step - %s\n%s' % (error, json.dumps(step, indent=2))
sys.exit(1)
- seed_steps = []
- for step in steps:
- seed_steps.append(step['name'])
- seed_steps.extend(step.get('seed_steps', []))
+ if seed_steps is None:
+ seed_steps = [s['name'] for s in steps]
stream = StructuredAnnotationStream(seed_steps=seed_steps)
ret_codes = []
« no previous file with comments | « no previous file | scripts/slave/annotated_run.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698