Extension SW: Add tests that serve web_accessible_resources from a SW.

chrome/browser/extensions/service_worker_apitest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind_helpers.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/notifications/desktop_notification_profile_util.h"
@@ skipping 551 matching lines @@
   // should fail.
   // Note that this also tests that service workers can be registered from tabs.
   EXPECT_TRUE(RunExtensionSubtest("service_worker/no_background", "page.html"));
 }
 
 IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, NotificationAPI) {
   EXPECT_TRUE(RunExtensionSubtest("service_worker/notifications/has_permission",
                                   "page.html"));
 }
 
+IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, WebAccessibleResourcesFetch) {
+  EXPECT_TRUE(RunExtensionSubtest("service_worker/web_accessible_resources",
+                                  "page.html"));
+}
+
+// This test loads a web page that has an iframe pointing to a
+// chrome-extension:// URL. The URL is listed in the extension's
+// web_accessible_resources. Initially the iframe is served from the extension's
+// resource file. After verifying that, we register a Service Worker that

[Devlin, 2015/12/17 17:37:34]

Do we actually need a real resource file here?  I'm envisioning the use case of
an extension that can handle arbitrary urls at runtime by registering a service
worker to serve anything from a certain path.  Can we expand this test to see if
an url without a backing resource file is handled by the SW?

[lazyboy, 2015/12/17 19:27:22]

No, we don't.
 I'm envisioning the use case of
Added a step that uses url from WAR manifest that is not present in
the extension resources.

+// controls the extension. Further requests to the same resource as before
+// should now be served by the Service Worker.
+IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, WebAccessibleResourcesIframeSrc) {
+  const Extension* extension = LoadExtensionWithFlags(
+      test_data_dir_.AppendASCII("service_worker/web_accessible_resources"),

[Devlin, 2015/12/17 17:37:34]

it looks like maybe these should be two separate extensions.  This one can just
be a background page that registers a sw to handle incoming fetch events, and
the other can do all the fancy claim stuff.

WDYT?

[lazyboy, 2015/12/17 19:27:22]

Done.

+      kFlagNone);
+  ASSERT_TRUE(extension);
+  ASSERT_TRUE(StartEmbeddedTestServer());
+  GURL page_url = embedded_test_server()->GetURL(
+      "/extensions/api_test/service_worker/web_accessible_resources/"
+      "webpage.html");
+
+  content::WebContents* web_contents = AddTab(browser(), page_url);
+  std::string result;
+  // webpage.html will create an iframe pointing to a resource from |extension|.
+  // Expect the resource to be served by the extension.
+  ASSERT_TRUE(content::ExecuteScriptAndExtractString(
+      web_contents,
+      base::StringPrintf("window.testIframe('%s')", extension->id().c_str()),
+      &result));
+  ASSERT_EQ("FROM_EXTENSION_RESOURCE", result);
+
+  // Now, register a Service Worker from the extension.
+  content::WebContents* extension_page_web_contents =
+      AddTab(browser(), extension->GetResourceURL("sw_register_page.html"));
+  ExtensionTestMessageListener service_worker_ready_listener("SW_READY", false);
+  service_worker_ready_listener.set_failure_message("SW_FAILED");
+  EXPECT_TRUE(content::ExecuteScript(extension_page_web_contents,
+                                     "window.registerServiceWorker()"));
+  ASSERT_TRUE(service_worker_ready_listener.WaitUntilSatisfied());
+
+  // webpage.html will create another iframe pointing to a resource from
+  // |extension| as before. But this time, the resource should be be served
+  // from the Service Worker.
+  ASSERT_TRUE(content::ExecuteScriptAndExtractString(
+      web_contents,
+      base::StringPrintf("window.testIframe('%s')", extension->id().c_str()),
+      &result));
+  ASSERT_EQ("FROM_SW_RESOURCE", result);
+}
+
 IN_PROC_BROWSER_TEST_F(ServiceWorkerBackgroundSyncTest, Sync) {
   const Extension* extension = LoadExtensionWithFlags(
       test_data_dir_.AppendASCII("service_worker/sync"), kFlagNone);
   ASSERT_TRUE(extension);
   ui_test_utils::NavigateToURL(browser(),
                                extension->GetResourceURL("page.html"));
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
 
   // Prevent firing by going offline.
@@ skipping 64 matching lines @@
   push_message_listener.set_failure_message("FAIL");
   gcm::IncomingMessage message;
   message.sender_id = "1234567890";
   message.raw_data = "testdata";
   message.decrypted = true;
   push_service()->OnMessage(app_identifier.app_id(), message);
   EXPECT_TRUE(push_message_listener.WaitUntilSatisfied());
 }
 
 }  // namespace extensions