Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 15325002: Stop generating and uploading incremental_results.json. (Closed)

Created:
7 years, 7 months ago by ojan
Modified:
7 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

Stop generating and uploading incremental_results.json. This file is no longer used by the flakiness dashboard. We can delete all the code associated with it. There's still a handful of functions in json_results_generator that are used by other classes. Mostly these functions are only used in one place and can just move there, but that seems appropriate to do in another patch. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150615

Patch Set 1 #

Total comments: 2

Messages

Total messages: 6 (0 generated)
ojan
7 years, 7 months ago (2013-05-17 20:34:14 UTC) #1
Julie Parent
https://codereview.chromium.org/15325002/diff/1/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py File Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (left): https://codereview.chromium.org/15325002/diff/1/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py#oldcode329 Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:329: """Writes the results of the test run as JSON ...
7 years, 7 months ago (2013-05-17 20:38:29 UTC) #2
Dirk Pranke
lgtm. nice!
7 years, 7 months ago (2013-05-17 20:39:43 UTC) #3
ojan
https://codereview.chromium.org/15325002/diff/1/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py File Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (left): https://codereview.chromium.org/15325002/diff/1/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py#oldcode329 Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:329: """Writes the results of the test run as JSON ...
7 years, 7 months ago (2013-05-17 20:41:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/15325002/1
7 years, 7 months ago (2013-05-17 22:24:27 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 23:35:23 UTC) #6
Message was sent while issue was closed.
Change committed as 150615

Powered by Google App Engine
This is Rietveld 408576698