Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15320003: Fix WebInputEventConversion conversion from Platform to Web KeyboardEvent. (Closed)

Created:
7 years, 7 months ago by kkania
Modified:
7 years, 7 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix WebInputEventConversion conversion from Platform to Web KeyboardEvent. It wasn't copying the full string data, since UChars are 2 bytes. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M LayoutTests/inspector-protocol/input/dispatchKeyEvent.html View 1 chunk +7 lines, -2 lines 0 comments Download
M LayoutTests/inspector-protocol/input/dispatchKeyEvent-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebInputEventConversion.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kkania
7 years, 7 months ago (2013-05-17 21:57:14 UTC) #1
chrisgao (Use stgao instead)
lgtm
7 years, 7 months ago (2013-05-17 22:03:50 UTC) #2
kkania
jochen: OWNERS (when you get a chance)
7 years, 7 months ago (2013-05-17 22:05:16 UTC) #3
jochen (gone - plz use gerrit)
lgtm
7 years, 7 months ago (2013-05-21 12:01:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/15320003/1
7 years, 7 months ago (2013-05-21 16:12:27 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9065
7 years, 7 months ago (2013-05-21 16:53:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/15320003/1
7 years, 7 months ago (2013-05-21 19:35:25 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 20:39:07 UTC) #8
Message was sent while issue was closed. 
Change committed as 150823

Powered by Google App Engine
This is Rietveld 408576698