Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5442)

Unified Diff: chrome/renderer/spellchecker/spellcheck_provider_mac_unittest.cc

Issue 15318004: Store feedback for spellcheck results from spelling service (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/spellchecker/spellcheck_provider_mac_unittest.cc
diff --git a/chrome/renderer/spellchecker/spellcheck_provider_mac_unittest.cc b/chrome/renderer/spellchecker/spellcheck_provider_mac_unittest.cc
index 847fbd88bc285eae6ad35e90a90dd77422ce5f1f..2873fb04a3c7a9fc12f9e732f2ef106d32337fef 100644
--- a/chrome/renderer/spellchecker/spellcheck_provider_mac_unittest.cc
+++ b/chrome/renderer/spellchecker/spellcheck_provider_mac_unittest.cc
@@ -5,6 +5,7 @@
#include <vector>
#include "base/utf_string_conversions.h"
+#include "chrome/common/spellcheck_marker.h"
#include "chrome/common/spellcheck_messages.h"
#include "chrome/common/spellcheck_result.h"
#include "chrome/renderer/spellchecker/spellcheck_provider_test.h"
@@ -51,7 +52,8 @@ TEST_F(SpellCheckProviderMacTest, SingleRoundtripSuccess) {
FakeTextCheckingCompletion completion;
provider_.RequestTextChecking(WebKit::WebString("hello "),
- &completion);
+ &completion,
+ std::vector<SpellCheckMarker>());
EXPECT_EQ(completion.completion_count_, 0U);
EXPECT_EQ(provider_.messages_.size(), 1U);
EXPECT_EQ(provider_.pending_text_request_size(), 1U);
@@ -68,10 +70,12 @@ TEST_F(SpellCheckProviderMacTest, SingleRoundtripSuccess) {
TEST_F(SpellCheckProviderMacTest, TwoRoundtripSuccess) {
FakeTextCheckingCompletion completion1;
provider_.RequestTextChecking(WebKit::WebString("hello "),
- &completion1);
+ &completion1,
+ std::vector<SpellCheckMarker>());
FakeTextCheckingCompletion completion2;
provider_.RequestTextChecking(WebKit::WebString("bye "),
- &completion2);
+ &completion2,
+ std::vector<SpellCheckMarker>());
EXPECT_EQ(completion1.completion_count_, 0U);
EXPECT_EQ(completion2.completion_count_, 0U);

Powered by Google App Engine
This is Rietveld 408576698