Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6706)

Unified Diff: chrome/browser/translate/translate_manager_browsertest.cc

Issue 15317007: Translate: split supporting language list handling to TranslateLanguageList (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: for review Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager_browsertest.cc
diff --git a/chrome/browser/translate/translate_manager_browsertest.cc b/chrome/browser/translate/translate_manager_browsertest.cc
index 90110faa714a67a1665d7157d6967d65a70da2c5..efb36a37fa70cb2b0a85d0a145cac1c9955b0247 100644
--- a/chrome/browser/translate/translate_manager_browsertest.cc
+++ b/chrome/browser/translate/translate_manager_browsertest.cc
@@ -21,6 +21,7 @@
#include "chrome/browser/prefs/session_startup_pref.h"
#include "chrome/browser/tab_contents/render_view_context_menu.h"
#include "chrome/browser/translate/translate_infobar_delegate.h"
+#include "chrome/browser/translate/translate_language_list.h"
#include "chrome/browser/translate/translate_manager.h"
#include "chrome/browser/translate/translate_prefs.h"
#include "chrome/browser/translate/translate_tab_helper.h"
@@ -279,9 +280,10 @@ class TranslateManagerBrowserTest : public ChromeRenderViewHostTestHarness,
std::string data;
if (success) {
- data = base::StringPrintf("%s{\"sl\": {\"bla\": \"bla\"}, \"%s\": {",
- TranslateManager::kLanguageListCallbackName,
- TranslateManager::kTargetLanguagesKey);
+ data = base::StringPrintf(
+ "%s{\"sl\": {\"bla\": \"bla\"}, \"%s\": {",
+ TranslateLanguageList::kLanguageListCallbackName,
+ TranslateLanguageList::kTargetLanguagesKey);
const char* comma = "";
for (size_t i = 0; i < languages.size(); ++i) {
data += base::StringPrintf(
@@ -630,7 +632,7 @@ TEST_F(TranslateManagerBrowserTest, FetchLanguagesFromTranslateServer) {
// First, get the default languages list:
std::vector<std::string> default_supported_languages;
- TranslateManager::GetSupportedLanguages(&default_supported_languages);
+ TranslateLanguageList::GetSupportedLanguages(&default_supported_languages);
// To make sure we got the defaults and don't confuse them with the mocks.
ASSERT_NE(default_supported_languages.size(), server_languages.size());
@@ -641,20 +643,20 @@ TEST_F(TranslateManagerBrowserTest, FetchLanguagesFromTranslateServer) {
// Check that we still get the defaults until the URLFetch has completed.
std::vector<std::string> current_supported_languages;
- TranslateManager::GetSupportedLanguages(&current_supported_languages);
+ TranslateLanguageList::GetSupportedLanguages(&current_supported_languages);
EXPECT_EQ(default_supported_languages, current_supported_languages);
// Also check that it didn't change if we failed the URL fetch.
SimulateSupportedLanguagesURLFetch(false, std::vector<std::string>());
current_supported_languages.clear();
- TranslateManager::GetSupportedLanguages(&current_supported_languages);
+ TranslateLanguageList::GetSupportedLanguages(&current_supported_languages);
EXPECT_EQ(default_supported_languages, current_supported_languages);
// Now check that we got the appropriate set of languages from the server.
TranslateManager::GetInstance()->FetchLanguageListFromTranslateServer(prefs);
SimulateSupportedLanguagesURLFetch(true, server_languages);
current_supported_languages.clear();
- TranslateManager::GetSupportedLanguages(&current_supported_languages);
+ TranslateLanguageList::GetSupportedLanguages(&current_supported_languages);
// Not sure we need to guarantee the order of languages, so we find them.
EXPECT_EQ(server_languages.size(), current_supported_languages.size());
for (size_t i = 0; i < server_languages.size(); ++i) {

Powered by Google App Engine
This is Rietveld 408576698