Issue 1531533002: wjm day 2 work

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1531533002: wjm day 2 work (Closed)

Created:
5 years ago by wjmaclean

Modified:
4 years, 11 months ago

Reviewers:

CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, droger+watchlist_chromium.org, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

wjm day 2 work Implement IPC, creation of FrameGuest. BUG=none

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+221 lines, -11 lines)			Patch
M	chrome/browser/guest_view/chrome_guest_view_message_filter.h	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/guest_view/chrome_guest_view_message_filter.cc	View	2 chunks	+81 lines, -2 lines	0 comments	Download
M	components/framelet/browser/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/framelet/common/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	components/framelet/common/DEPS	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	components/framelet/common/framelet_constants.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/framelet/common/framelet_constants.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	components/framelet/common/framelet_message_generator.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
A +	components/framelet/common/framelet_message_generator.cc	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	components/framelet/common/framelet_messages.h	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	components/framelet/renderer/DEPS	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	components/framelet/renderer/framelet_container.h	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	components/framelet/renderer/framelet_container.cc	View	1 chunk	+62 lines, -1 line	0 comments	Download
M	ipc/ipc_message_start.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1047683002 Patch 1