Issue 15314004: Move SkImage::encode to SkImage_Codec.cpp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15314004: Move SkImage::encode to SkImage_Codec.cpp. (Closed)

Created:
7 years, 7 months ago by scroggo

Modified:
7 years, 7 months ago

Reviewers:
robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Move SkImage::encode to SkImage_Codec.cpp. Chrome depends on SkImage.cpp, but does not include SkImageDecoder, so having SkImage::encode in SkImage.cpp breaks chromium. Temporarily fix the problem by moving the implementation into SkImage_Codec.cpp. The larger fix will be to solve https://code.google.com/p/skia/issues/detail?id=1275 Committed: http://code.google.com/p/skia/source/detail?r=9204

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -29 lines)			Patch
M	gyp/tools.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/image/SkImage.cpp	View	3 chunks	+0 lines, -29 lines	0 comments	Download
M	src/image/SkImage_Codec.cpp	View	1 chunk	+37 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/15314004/1

7 years, 7 months ago (2013-05-20 23:51:03 UTC) #3

Message was sent while issue was closed.

Change committed as 9204