Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 15313004: Escape commas in Chrome startup arguments for telemetry tests on CrOS. (Closed)

Created:
7 years, 7 months ago by Tim Song
Modified:
7 years, 7 months ago
Reviewers:
achuith, achuithb
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Escape commas in Chrome startup arguments for telemetry tests on CrOS. BUG=239161 TEST=run_tests pass for tests with commas in startup arguments NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200921

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/telemetry/telemetry/core/chrome/cros_browser_backend.py View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Tim Song
This is the follow-up change to patching dbus-send to take advantage of comma escaping. PTAL.
7 years, 7 months ago (2013-05-17 20:24:24 UTC) #1
achuithb
lgtm
7 years, 7 months ago (2013-05-17 21:12:50 UTC) #2
nduca
Thanks again Tim for threading the needle on this one. I know this was a ...
7 years, 7 months ago (2013-05-17 22:36:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/15313004/2001
7 years, 7 months ago (2013-05-17 23:23:33 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 23:24:27 UTC) #5
Message was sent while issue was closed.
Change committed as 200921

Powered by Google App Engine
This is Rietveld 408576698