Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: chrome/browser/translate/translate_manager_metrics.cc

Issue 15311006: Added and replaced some UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (Rebasing) Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager_metrics.cc
diff --git a/chrome/browser/translate/translate_manager_metrics.cc b/chrome/browser/translate/translate_manager_metrics.cc
index 5b11d30548b4e0b698074cad0e3ff7a83357eff0..0098c74a4f0a140cdced48d33318e0dab20b5ab1 100644
--- a/chrome/browser/translate/translate_manager_metrics.cc
+++ b/chrome/browser/translate/translate_manager_metrics.cc
@@ -4,8 +4,12 @@
#include "chrome/browser/translate/translate_manager_metrics.h"
+#include <string>
+
#include "base/basictypes.h"
#include "base/metrics/histogram.h"
+#include "base/metrics/sparse_histogram.h"
+#include "chrome/browser/language_usage_metrics.h"
namespace {
@@ -17,6 +21,8 @@ const char kTranslateReportLanguageDetectionError[] =
"Translate.ReportLanguageDetectionError";
const char kTranslateServerReportedUnsupportedLanguage[] =
"Translate.ServerReportedUnsupportedLanguage";
+const char kTranslateUnsupportedLanguageAtInitiation[] =
+ "Translate.UnsupportedLanguageAtInitiation";
struct MetricsEntry {
TranslateManagerMetrics::MetricsNameIndex index;
@@ -31,6 +37,8 @@ const MetricsEntry kMetricsEntries[] = {
kTranslateReportLanguageDetectionError },
{ TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE,
kTranslateServerReportedUnsupportedLanguage },
+ { TranslateManagerMetrics::UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION,
+ kTranslateUnsupportedLanguageAtInitiation },
};
COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateManagerMetrics::UMA_MAX,
@@ -54,6 +62,12 @@ void ReportUnsupportedLanguage() {
UMA_HISTOGRAM_COUNTS(kTranslateServerReportedUnsupportedLanguage, 1);
}
+void ReportUnsupportedLanguageAtInitiation(const std::string& language) {
+ int language_code = LanguageUsageMetrics::ToLanguageCode(language);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateUnsupportedLanguageAtInitiation,
+ language_code);
+}
+
const char* GetMetricsName(MetricsNameIndex index) {
for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) {
if (kMetricsEntries[i].index == index)
« no previous file with comments | « chrome/browser/translate/translate_manager_metrics.h ('k') | chrome/browser/translate/translate_manager_metrics_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698