Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2869)

Unified Diff: chrome/browser/translate/translate_manager_metrics.cc

Issue 15311006: Added and replaced some UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modified the comments in histograms.xml Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager_metrics.cc
diff --git a/chrome/browser/translate/translate_manager_metrics.cc b/chrome/browser/translate/translate_manager_metrics.cc
index 5b11d30548b4e0b698074cad0e3ff7a83357eff0..22a6ef7970ffeb8e82fbe1d03a721fbadcd2c96c 100644
--- a/chrome/browser/translate/translate_manager_metrics.cc
+++ b/chrome/browser/translate/translate_manager_metrics.cc
@@ -4,8 +4,12 @@
#include "chrome/browser/translate/translate_manager_metrics.h"
+#include <string>
+
#include "base/basictypes.h"
#include "base/metrics/histogram.h"
+#include "base/metrics/sparse_histogram.h"
+#include "chrome/browser/language_usage_metrics.h"
namespace {
@@ -15,8 +19,10 @@ const char kTranslateInitiationStatus[] =
"Translate.InitiationStatus";
const char kTranslateReportLanguageDetectionError[] =
"Translate.ReportLanguageDetectionError";
-const char kTranslateServerReportedUnsupportedLanguage[] =
- "Translate.ServerReportedUnsupportedLanguage";
+const char kTranslateUnavailableLanguage[] =
+ "Translate.UnavailableLanguage";
+const char kTranslateUnsupportedLanguageAtInitiation[] =
+ "Translate.UnsupportedLanguageAtInitiation";
struct MetricsEntry {
TranslateManagerMetrics::MetricsNameIndex index;
@@ -29,8 +35,10 @@ const MetricsEntry kMetricsEntries[] = {
kTranslateInitiationStatus },
{ TranslateManagerMetrics::UMA_LANGUAGE_DETECTION_ERROR,
kTranslateReportLanguageDetectionError },
- { TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE,
- kTranslateServerReportedUnsupportedLanguage },
+ { TranslateManagerMetrics::UMA_UNAVAILABLE_LANGUAGE,
+ kTranslateUnavailableLanguage },
+ { TranslateManagerMetrics::UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION,
+ kTranslateUnsupportedLanguageAtInitiation },
};
COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateManagerMetrics::UMA_MAX,
@@ -50,8 +58,16 @@ void ReportLanguageDetectionError() {
UMA_HISTOGRAM_COUNTS(kTranslateReportLanguageDetectionError, 1);
}
-void ReportUnsupportedLanguage() {
- UMA_HISTOGRAM_COUNTS(kTranslateServerReportedUnsupportedLanguage, 1);
+void ReportUnavailableLanguage(const std::string& language) {
+ int language_code = LanguageUsageMetrics::ToLanguageCode(language);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateUnavailableLanguage,
+ language_code);
+}
+
+void ReportUnsupportedLanguageAtInitiation(const std::string& language) {
+ int language_code = LanguageUsageMetrics::ToLanguageCode(language);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateUnsupportedLanguageAtInitiation,
+ language_code);
}
const char* GetMetricsName(MetricsNameIndex index) {

Powered by Google App Engine
This is Rietveld 408576698