Added and replaced some UMAs

Added and replaced some UMAs.

1) Deprecated the UMA key "Translate.ServerReportedUnsupportedLanguage" (the internal histograms.xml should be modified later).

2) Added the UMA key "Translate.UnavailableLanguage" which is sent when the language is reported by the server but not available for the user locale.
[We decided to implement a new UMA instead of 2) in another CL]

3) Added the UMA key "Translate.UnsupportedLanguageAtInitiation" which is sent when the language was unsupported during initialization.

BUG=242142
TEST=unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202836

[hajimehoshi, 2013-05-21 09:47:50]

Can you take a look?

[Takashi Toyoshima, 2013-05-21 11:11:43]

lgtm with nits for browser/translate.
Please ask other OWNERS reviews.
Also, other guys will suggest better ideas on English descriptions.

https://codereview.chromium.org/15311006/diff/1/chrome/browser/language_usage...
File chrome/browser/language_usage_metrics.cc (right):

https://codereview.chromium.org/15311006/diff/1/chrome/browser/language_usage...
chrome/browser/language_usage_metrics.cc:10: #include "base/string_util.h"
can you remove this?

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager.cc (right):

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager.cc:320: std::string locale =
g_browser_process->GetApplicationLocale();
const std::string&

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager.cc:775: // TODO(jcivelli):
http://crbug.com/9390 We should change the "after
remove this TODO.

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager.cc:778: std::string language =
details->source_language;
const std::string&

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager.h (right):

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager.h:116: // Returns true if |language|
is shown as a candidate in the inforbar.
This description looks vague.
"If infobar can display a name for |language| in current UI locale" or
something?

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager_metrics.cc (right):

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager_metrics.cc:22: const char
kTranslateServerReportedUnsupportedLanguage[] =
Remove value for the obsoleted UMA.

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager_metrics.cc:40: {
TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE,
remove obsoleted one.

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager_metrics.h (right):

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager_metrics.h:17:
UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE, // obsolete
Remove obsoleted enum ID.
It's ok to reuse the same enum ID for another uMA.

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager_metrics_unittest.cc (right):

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager_metrics_unittest.cc:154: EXPECT_EQ(1,
recorder.GetTotalCount());
Can we check a reported value for "en"?

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager_metrics_unittest.cc:162: EXPECT_EQ(1,
recorder.GetTotalCount());
ditto.

https://codereview.chromium.org/15311006/diff/1/tools/metrics/histograms/hist...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/15311006/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:8591: server.
for the user locale -> to show in infobar UI in the user locale
but reported by the server -> but used by the translate server

https://codereview.chromium.org/15311006/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:8598: translation is initialized.
initialized -> going to be initiated

https://codereview.chromium.org/15311006/diff/1/ui/base/l10n/l10n_util.h
File ui/base/l10n/l10n_util.h (right):

https://codereview.chromium.org/15311006/diff/1/ui/base/l10n/l10n_util.h#newc...
ui/base/l10n/l10n_util.h:26: bool IsLocaleNameTranslated(const std::string&
locale,
UI_EXPORT

[Ilya Sherman, 2013-05-21 22:53:59]

https://codereview.chromium.org/15311006/diff/1/chrome/common/metrics/metrics...
File chrome/common/metrics/metrics_util.h (right):

https://codereview.chromium.org/15311006/diff/1/chrome/common/metrics/metrics...
chrome/common/metrics/metrics_util.h:25: int ToLanguageCode(const std::string
&locale);
This is not an appropriate location for this function.  Please move it to a more
granular location.

[hajimehoshi, 2013-05-22 04:19:27]

Thank you!

https://codereview.chromium.org/15311006/diff/1/chrome/browser/language_usage...
File chrome/browser/language_usage_metrics.cc (right):

https://codereview.chromium.org/15311006/diff/1/chrome/browser/language_usage...
chrome/browser/language_usage_metrics.cc:10: #include "base/string_util.h"
On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> can you remove this?

Done.

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager.cc (right):

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager.cc:320: std::string locale =
g_browser_process->GetApplicationLocale();
On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> const std::string&

Done.

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager.cc:775: // TODO(jcivelli):
http://crbug.com/9390 We should change the "after
On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> remove this TODO.

Done.

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager.cc:778: std::string language =
details->source_language;
On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> const std::string&

Done.

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager.h (right):

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager.h:116: // Returns true if |language|
is shown as a candidate in the inforbar.
On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> This description looks vague.
> "If infobar can display a name for |language| in current UI locale" or
> something?

Done.

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager_metrics.cc (right):

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager_metrics.cc:22: const char
kTranslateServerReportedUnsupportedLanguage[] =
On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> Remove value for the obsoleted UMA.

Done.

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager_metrics.cc:40: {
TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE,
On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> remove obsoleted one.

Done.

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager_metrics.h (right):

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager_metrics.h:17:
UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE, // obsolete
On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> Remove obsoleted enum ID.
> It's ok to reuse the same enum ID for another uMA.

Done.

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager_metrics_unittest.cc (right):

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager_metrics_unittest.cc:154: EXPECT_EQ(1,
recorder.GetTotalCount());
On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> Can we check a reported value for "en"?

Done.

https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager_metrics_unittest.cc:162: EXPECT_EQ(1,
recorder.GetTotalCount());
On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> ditto.

Done.

https://codereview.chromium.org/15311006/diff/1/chrome/common/metrics/metrics...
File chrome/common/metrics/metrics_util.h (right):

https://codereview.chromium.org/15311006/diff/1/chrome/common/metrics/metrics...
chrome/common/metrics/metrics_util.h:25: int ToLanguageCode(const std::string
&locale);
I'll create chrome/browser/metrics/metrics_util.{cc|h} and move this function
there.

On 2013/05/21 22:53:59, Ilya Sherman wrote:
> This is not an appropriate location for this function.  Please move it to a
more
> granular location.

https://codereview.chromium.org/15311006/diff/1/tools/metrics/histograms/hist...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/15311006/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:8591: server.
On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> for the user locale -> to show in infobar UI in the user locale
> but reported by the server -> but used by the translate server

Done.

https://codereview.chromium.org/15311006/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:8598: translation is initialized.
On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> initialized -> going to be initiated

Done.

https://codereview.chromium.org/15311006/diff/1/ui/base/l10n/l10n_util.h
File ui/base/l10n/l10n_util.h (right):

https://codereview.chromium.org/15311006/diff/1/ui/base/l10n/l10n_util.h#newc...
ui/base/l10n/l10n_util.h:26: bool IsLocaleNameTranslated(const std::string&
locale,
On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> UI_EXPORT

Done.

[hajimehoshi, 2013-05-22 04:29:28]

Can you guys take a look at this CL?  Thank you in advance.

isherman:
I added some files to chrome/browser/metrics/*.

sky:
I'd like you to see chrome/*.gypi files.

jshin:
I'd like you to see files under ui/base/l10n.



On 2013/05/22 04:19:27, hajimehoshi wrote:
> Thank you!
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/language_usage...
> File chrome/browser/language_usage_metrics.cc (right):
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/language_usage...
> chrome/browser/language_usage_metrics.cc:10: #include "base/string_util.h"
> On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> > can you remove this?
> 
> Done.
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
> File chrome/browser/translate/translate_manager.cc (right):
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
> chrome/browser/translate/translate_manager.cc:320: std::string locale =
> g_browser_process->GetApplicationLocale();
> On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> > const std::string&
> 
> Done.
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
> chrome/browser/translate/translate_manager.cc:775: // TODO(jcivelli):
> http://crbug.com/9390 We should change the "after
> On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> > remove this TODO.
> 
> Done.
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
> chrome/browser/translate/translate_manager.cc:778: std::string language =
> details->source_language;
> On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> > const std::string&
> 
> Done.
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
> File chrome/browser/translate/translate_manager.h (right):
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
> chrome/browser/translate/translate_manager.h:116: // Returns true if
|language|
> is shown as a candidate in the inforbar.
> On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> > This description looks vague.
> > "If infobar can display a name for |language| in current UI locale" or
> > something?
> 
> Done.
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
> File chrome/browser/translate/translate_manager_metrics.cc (right):
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
> chrome/browser/translate/translate_manager_metrics.cc:22: const char
> kTranslateServerReportedUnsupportedLanguage[] =
> On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> > Remove value for the obsoleted UMA.
> 
> Done.
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
> chrome/browser/translate/translate_manager_metrics.cc:40: {
> TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE,
> On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> > remove obsoleted one.
> 
> Done.
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
> File chrome/browser/translate/translate_manager_metrics.h (right):
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
> chrome/browser/translate/translate_manager_metrics.h:17:
> UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE, // obsolete
> On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> > Remove obsoleted enum ID.
> > It's ok to reuse the same enum ID for another uMA.
> 
> Done.
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
> File chrome/browser/translate/translate_manager_metrics_unittest.cc (right):
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
> chrome/browser/translate/translate_manager_metrics_unittest.cc:154:
EXPECT_EQ(1,
> recorder.GetTotalCount());
> On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> > Can we check a reported value for "en"?
> 
> Done.
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/browser/translate/tran...
> chrome/browser/translate/translate_manager_metrics_unittest.cc:162:
EXPECT_EQ(1,
> recorder.GetTotalCount());
> On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> > ditto.
> 
> Done.
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/common/metrics/metrics...
> File chrome/common/metrics/metrics_util.h (right):
> 
>
https://codereview.chromium.org/15311006/diff/1/chrome/common/metrics/metrics...
> chrome/common/metrics/metrics_util.h:25: int ToLanguageCode(const std::string
> &locale);
> I'll create chrome/browser/metrics/metrics_util.{cc|h} and move this function
> there.
> 
> On 2013/05/21 22:53:59, Ilya Sherman wrote:
> > This is not an appropriate location for this function.  Please move it to a
> more
> > granular location.
> 
>
https://codereview.chromium.org/15311006/diff/1/tools/metrics/histograms/hist...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/15311006/diff/1/tools/metrics/histograms/hist...
> tools/metrics/histograms/histograms.xml:8591: server.
> On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> > for the user locale -> to show in infobar UI in the user locale
> > but reported by the server -> but used by the translate server
> 
> Done.
> 
>
https://codereview.chromium.org/15311006/diff/1/tools/metrics/histograms/hist...
> tools/metrics/histograms/histograms.xml:8598: translation is initialized.
> On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> > initialized -> going to be initiated
> 
> Done.
> 
> https://codereview.chromium.org/15311006/diff/1/ui/base/l10n/l10n_util.h
> File ui/base/l10n/l10n_util.h (right):
> 
>
https://codereview.chromium.org/15311006/diff/1/ui/base/l10n/l10n_util.h#newc...
> ui/base/l10n/l10n_util.h:26: bool IsLocaleNameTranslated(const std::string&
> locale,
> On 2013/05/21 11:11:43, Takashi Toyoshima (chromium) wrote:
> > UI_EXPORT
> 
> Done.

[Ilya Sherman, 2013-05-22 07:51:36]

https://codereview.chromium.org/15311006/diff/1/chrome/common/metrics/metrics...
File chrome/common/metrics/metrics_util.h (right):

https://codereview.chromium.org/15311006/diff/1/chrome/common/metrics/metrics...
chrome/common/metrics/metrics_util.h:25: int ToLanguageCode(const std::string
&locale);
This code doesn't belong under metrics/, whether in chrome/browser or
chrome/common.  metrics/ is for much more core metrics code.  Please move this
to somewhere that is specific to language detection or translate.

On 2013/05/22 04:19:27, hajimehoshi wrote:
> I'll create chrome/browser/metrics/metrics_util.{cc|h} and move this function
> there.
> 
> On 2013/05/21 22:53:59, Ilya Sherman wrote:
> > This is not an appropriate location for this function.  Please move it to a
> more
> > granular location.
>

[hajimehoshi, 2013-05-22 08:08:36]

Thank you.

+sky, *.gypi was rolled back and you no longer have to review this CL.  Thank
you.

https://codereview.chromium.org/15311006/diff/1/chrome/common/metrics/metrics...
File chrome/common/metrics/metrics_util.h (right):

https://codereview.chromium.org/15311006/diff/1/chrome/common/metrics/metrics...
chrome/common/metrics/metrics_util.h:25: int ToLanguageCode(const std::string
&locale);
Thank you for your quick review.  I'll this code to LanguageUsageMetrics as a
static function.

On 2013/05/22 07:51:36, Ilya Sherman wrote:
> This code doesn't belong under metrics/, whether in chrome/browser or
> chrome/common.  metrics/ is for much more core metrics code.  Please move this
> to somewhere that is specific to language detection or translate.
> 
> On 2013/05/22 04:19:27, hajimehoshi wrote:
> > I'll create chrome/browser/metrics/metrics_util.{cc|h} and move this
function
> > there.
> > 
> > On 2013/05/21 22:53:59, Ilya Sherman wrote:
> > > This is not an appropriate location for this function.  Please move it to
a
> > more
> > > granular location.
> > 
>

[Ilya Sherman, 2013-05-22 08:34:31]

https://codereview.chromium.org/15311006/diff/22001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/15311006/diff/22001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:8614: but used by the translate server.
I don't understand this description -- could you reword it?  What I'd like to
better understand is: When is this metric logged, and how should it be
interpreted?

https://codereview.chromium.org/15311006/diff/22001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:8621: translation is going to be
initialized.
Likewise, I don't understand what the user flow is to get here.  Could you
expand or reword this comment to be a little clearer?

[hajimehoshi, 2013-05-23 00:59:33]

+toyoshim, would you give me an advice later?

On 2013/05/22 08:34:31, Ilya Sherman wrote:
>
https://codereview.chromium.org/15311006/diff/22001/tools/metrics/histograms/...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/15311006/diff/22001/tools/metrics/histograms/...
> tools/metrics/histograms/histograms.xml:8614: but used by the translate
server.
> I don't understand this description -- could you reword it?  What I'd like to
> better understand is: When is this metric logged, and how should it be
> interpreted?
> 
>
https://codereview.chromium.org/15311006/diff/22001/tools/metrics/histograms/...
> tools/metrics/histograms/histograms.xml:8621: translation is going to be
> initialized.
> Likewise, I don't understand what the user flow is to get here.  Could you
> expand or reword this comment to be a little clearer?

[Takashi Toyoshima, 2013-05-23 01:26:56]

Ilya: I answered. Does it make sense?

Hajime: Does it help you to reword them?

https://codereview.chromium.org/15311006/diff/22001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/15311006/diff/22001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:8614: but used by the translate server.
This metrics mean that Translate server returns a language code which is not
supported by l10n library in Chrome, or ICU. Basically this metrics should not
be reported. But supporting language list of Translate Server and Chrome l10n
library can be different. We should monitor it to fix broken UI potentially
caused by server side update.

https://codereview.chromium.org/15311006/diff/22001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:8621: translation is going to be
initialized.
Here, unsupported language means Google Translate doesn't support translation
for the language. This metrics is used to know which unsupported language is
important for Chrome/Google Translate.

[hajimehoshi, 2013-05-23 02:30:00]

Thank you!

https://chromiumcodereview.appspot.com/15311006/diff/22001/tools/metrics/hist...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/15311006/diff/22001/tools/metrics/hist...
tools/metrics/histograms/histograms.xml:8614: but used by the translate server.
On 2013/05/23 01:26:56, Takashi Toyoshima (chromium) wrote:
> This metrics mean that Translate server returns a language code which is not
> supported by l10n library in Chrome, or ICU. Basically this metrics should not
> be reported. But supporting language list of Translate Server and Chrome l10n
> library can be different. We should monitor it to fix broken UI potentially
> caused by server side update.

Done.

https://chromiumcodereview.appspot.com/15311006/diff/22001/tools/metrics/hist...
tools/metrics/histograms/histograms.xml:8621: translation is going to be
initialized.
On 2013/05/23 01:26:56, Takashi Toyoshima (chromium) wrote:
> Here, unsupported language means Google Translate doesn't support translation
> for the language. This metrics is used to know which unsupported language is
> important for Chrome/Google Translate.

Done.

[Ilya Sherman, 2013-05-23 08:30:52]

LGTM, thanks.

https://chromiumcodereview.appspot.com/15311006/diff/28001/tools/metrics/hist...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/15311006/diff/28001/tools/metrics/hist...
tools/metrics/histograms/histograms.xml:8618: that of translation server may
differ.
Thanks for expanding this -- much clearer now!

nit: Suggested rewording to incorporate a handful of minor edits:

"Logs the source language when a Translate infobar is shown with an unsupported
source language.  There are two cases when this can occur:  The first is when
the user selects automatic language detection and the detected language is
unsupported by the translation server because it is too minor.  The other is
when the infobar UI is broken and the user can directly choose the language. 
The former can happen because the language set of Chrome and that of the
translation server may differ."

https://chromiumcodereview.appspot.com/15311006/diff/28001/tools/metrics/hist...
tools/metrics/histograms/histograms.xml:8627: unsupported language is for Google
translate by this metrics.
nit: Suggested rewording to incorporate a handful of minor edits:

"Logs an unsupported source language detected during initiation of the Translate
feature.  This is reported when the language detector successfully detects the
language of the webpage, but the language is not supported by the translation
server because it is too minor.  This metric allows us to assess how important
the unsupported language is for Google translate."

[hajimehoshi, 2013-05-23 08:49:22]

Thank you!

https://chromiumcodereview.appspot.com/15311006/diff/28001/tools/metrics/hist...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/15311006/diff/28001/tools/metrics/hist...
tools/metrics/histograms/histograms.xml:8618: that of translation server may
differ.
On 2013/05/23 08:30:52, Ilya Sherman wrote:
> Thanks for expanding this -- much clearer now!
> 
> nit: Suggested rewording to incorporate a handful of minor edits:
> 
> "Logs the source language when a Translate infobar is shown with an
unsupported
> source language.  There are two cases when this can occur:  The first is when
> the user selects automatic language detection and the detected language is
> unsupported by the translation server because it is too minor.  The other is
> when the infobar UI is broken and the user can directly choose the language. 
> The former can happen because the language set of Chrome and that of the
> translation server may differ."

Done.

https://chromiumcodereview.appspot.com/15311006/diff/28001/tools/metrics/hist...
tools/metrics/histograms/histograms.xml:8627: unsupported language is for Google
translate by this metrics.
On 2013/05/23 08:30:52, Ilya Sherman wrote:
> nit: Suggested rewording to incorporate a handful of minor edits:
> 
> "Logs an unsupported source language detected during initiation of the
Translate
> feature.  This is reported when the language detector successfully detects the
> language of the webpage, but the language is not supported by the translation
> server because it is too minor.  This metric allows us to assess how important
> the unsupported language is for Google translate."

Done.

[commit-bot: I haz the power, 2013-05-23 09:05:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/15311006/38001

[commit-bot: I haz the power, 2013-05-23 09:14:59]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-05-24 02:21:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/15311006/49001

[hajimehoshi, 2013-05-24 02:34:10]

+jshin, can you take a look at ui/base/*?

+sky, can you take a look at chrome/browser/language_usage_metrics.*?

Thank you in advance.

On 2013/05/24 02:21:00, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>
https://chromium-status.appspot.com/cq/hajimehoshi%40chromium.org/15311006/49001

[sky, 2013-05-24 15:28:27]

LGTM

https://chromiumcodereview.appspot.com/15311006/diff/49001/chrome/browser/lan...
File chrome/browser/language_usage_metrics.h (right):

https://chromiumcodereview.appspot.com/15311006/diff/49001/chrome/browser/lan...
chrome/browser/language_usage_metrics.h:39: LanguageUsageMetrics();
DISALLOW_IMPLICIT_CONSTRUCTORS.

[hajimehoshi, 2013-05-27 00:55:22]

Thank you!

https://chromiumcodereview.appspot.com/15311006/diff/49001/chrome/browser/lan...
File chrome/browser/language_usage_metrics.h (right):

https://chromiumcodereview.appspot.com/15311006/diff/49001/chrome/browser/lan...
chrome/browser/language_usage_metrics.h:39: LanguageUsageMetrics();
On 2013/05/24 15:28:28, sky wrote:
> DISALLOW_IMPLICIT_CONSTRUCTORS.

Done.

[hajimehoshi, 2013-05-28 01:25:41]

ping +jshin

On 2013/05/27 00:55:22, hajimehoshi wrote:
> Thank you!
> 
>
https://chromiumcodereview.appspot.com/15311006/diff/49001/chrome/browser/lan...
> File chrome/browser/language_usage_metrics.h (right):
> 
>
https://chromiumcodereview.appspot.com/15311006/diff/49001/chrome/browser/lan...
> chrome/browser/language_usage_metrics.h:39: LanguageUsageMetrics();
> On 2013/05/24 15:28:28, sky wrote:
> > DISALLOW_IMPLICIT_CONSTRUCTORS.
> 
> Done.

[hajimehoshi, 2013-05-29 07:36:39]

Sorry for confusion, but we decided to change the direction.  We are going to
implement a new UMA instead of UMA_UNAVAILABLE_LANGUAGE in another CL.

On 2013/05/28 01:25:41, hajimehoshi wrote:
> ping +jshin
> 
> On 2013/05/27 00:55:22, hajimehoshi wrote:
> > Thank you!
> > 
> >
>
https://chromiumcodereview.appspot.com/15311006/diff/49001/chrome/browser/lan...
> > File chrome/browser/language_usage_metrics.h (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/15311006/diff/49001/chrome/browser/lan...
> > chrome/browser/language_usage_metrics.h:39: LanguageUsageMetrics();
> > On 2013/05/24 15:28:28, sky wrote:
> > > DISALLOW_IMPLICIT_CONSTRUCTORS.
> > 
> > Done.

[commit-bot: I haz the power, 2013-05-29 07:43:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/15311006/83001

[commit-bot: I haz the power, 2013-05-29 08:04:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/15311006/86001

[commit-bot: I haz the power, 2013-05-29 11:26:56]

Change committed as 202836

[hajimehoshi, 2013-05-30 07:11:16]

I noticed that 1) is not done because I was confused by rebasing or something.
I'll do that at https://codereview.chromium.org/15987004/

On 2013/05/29 11:26:56, I haz the power (commit-bot) wrote:
> Change committed as 202836