Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 15305011: [CrOS MP] Add --multi-profiles switch in some tests (Closed)

Created:
7 years, 7 months ago by Nikita (slow)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, pneubeck (no reviews)
Visibility:
Public.

Description

[CrOS MP] Add --multi-profiles switch in some tests * ProfileHelperTest * ExistingUserControllerTest * ExistingUserControllerPublicSessionTest * ExtensionNetworkingPrivateApiTest BUG=230464 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201306

Patch Set 1 #

Patch Set 2 : ExtensionNetworkingPrivateApiTest #

Patch Set 3 : merge #

Total comments: 1

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -32 lines) Patch
M chrome/browser/chromeos/extensions/networking_private_apitest.cc View 1 2 3 4 chunks +26 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 2 3 13 chunks +22 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper_browsertest.cc View 1 2 3 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nikita (slow)
These are the first tests that will be running for both existing and multi-profiles setup. ...
7 years, 7 months ago (2013-05-20 08:49:08 UTC) #1
Nikita (slow)
cc:pneubeck
7 years, 7 months ago (2013-05-20 10:54:38 UTC) #2
Nikita (slow)
Zel need OWNERS lgtm for chrome/browser/chromeos/extensions/*
7 years, 7 months ago (2013-05-21 09:49:35 UTC) #3
Nikita (slow)
+Dmitry for code review
7 years, 7 months ago (2013-05-21 09:50:28 UTC) #4
pneubeck (no reviews)
networking apitest lgtm.
7 years, 7 months ago (2013-05-21 10:33:36 UTC) #5
Dmitry Polukhin
LGTM but please run more trybots for Chrome OS.
7 years, 7 months ago (2013-05-21 10:38:23 UTC) #6
zel
lgtm https://codereview.chromium.org/15305011/diff/14001/chrome/browser/chromeos/extensions/networking_private_apitest.cc File chrome/browser/chromeos/extensions/networking_private_apitest.cc (right): https://codereview.chromium.org/15305011/diff/14001/chrome/browser/chromeos/extensions/networking_private_apitest.cc#newcode68 chrome/browser/chromeos/extensions/networking_private_apitest.cc:68: } nit: no {}
7 years, 7 months ago (2013-05-21 14:06:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/15305011/20001
7 years, 7 months ago (2013-05-21 15:09:43 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 15:13:04 UTC) #9
Message was sent while issue was closed.
Change committed as 201306

Powered by Google App Engine
This is Rietveld 408576698