Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: src/hydrogen.cc

Issue 15303004: Implement HChange support for Smis and use it in Load/StoreNameField (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4381 matching lines...) Expand 10 before | Expand all | Expand 10 after
4392 for (HInstruction* current = blocks_[i]->first(); 4392 for (HInstruction* current = blocks_[i]->first();
4393 current != NULL; 4393 current != NULL;
4394 current = current->next()) { 4394 current = current->next()) {
4395 if (current->IsChange()) { 4395 if (current->IsChange()) {
4396 HChange* change = HChange::cast(current); 4396 HChange* change = HChange::cast(current);
4397 // Propagate flags for negative zero checks upwards from conversions 4397 // Propagate flags for negative zero checks upwards from conversions
4398 // int32-to-tagged and int32-to-double. 4398 // int32-to-tagged and int32-to-double.
4399 Representation from = change->value()->representation(); 4399 Representation from = change->value()->representation();
4400 ASSERT(from.Equals(change->from())); 4400 ASSERT(from.Equals(change->from()));
4401 if (from.IsInteger32()) { 4401 if (from.IsInteger32()) {
4402 ASSERT(change->to().IsTagged() || change->to().IsDouble()); 4402 ASSERT(change->to().IsTagged() ||
4403 change->to().IsDouble() ||
4404 change->to().IsSmi());
4403 ASSERT(visited.IsEmpty()); 4405 ASSERT(visited.IsEmpty());
4404 PropagateMinusZeroChecks(change->value(), &visited); 4406 PropagateMinusZeroChecks(change->value(), &visited);
4405 visited.Clear(); 4407 visited.Clear();
4406 } 4408 }
4407 } 4409 }
4408 } 4410 }
4409 } 4411 }
4410 } 4412 }
4411 4413
4412 4414
(...skipping 8056 matching lines...) Expand 10 before | Expand all | Expand 10 after
12469 } 12471 }
12470 } 12472 }
12471 12473
12472 #ifdef DEBUG 12474 #ifdef DEBUG
12473 if (graph_ != NULL) graph_->Verify(false); // No full verify. 12475 if (graph_ != NULL) graph_->Verify(false); // No full verify.
12474 if (allocator_ != NULL) allocator_->Verify(); 12476 if (allocator_ != NULL) allocator_->Verify();
12475 #endif 12477 #endif
12476 } 12478 }
12477 12479
12478 } } // namespace v8::internal 12480 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698